Re: [PATCH 4/6] staging: qlge: qlge_main: Simplify while statements.

2020-07-14 Thread Dan Carpenter
On Tue, Jul 14, 2020 at 12:10:22PM +0530, Suraj Upadhyay wrote: > On Mon, Jul 13, 2020 at 05:12:35PM +0300, Dan Carpenter wrote: > > On Mon, Jul 13, 2020 at 05:50:14PM +0530, Suraj Upadhyay wrote: > > > Simplify while loops into more readable and simple for loops. > > > > > > > I don't think

Re: [PATCH 4/6] staging: qlge: qlge_main: Simplify while statements.

2020-07-14 Thread Suraj Upadhyay
On Tue, Jul 14, 2020 at 02:41:37PM +0900, Benjamin Poirier wrote: > On 2020-07-13 17:50 +0530, Suraj Upadhyay wrote: > > Simplify while loops into more readable and simple for loops. > > > > Signed-off-by: Suraj Upadhyay > > --- > [...] > > @@ -1824,7 +1821,7 @@ static struct sk_buff

Re: [PATCH 4/6] staging: qlge: qlge_main: Simplify while statements.

2020-07-14 Thread Suraj Upadhyay
On Mon, Jul 13, 2020 at 05:12:35PM +0300, Dan Carpenter wrote: > On Mon, Jul 13, 2020 at 05:50:14PM +0530, Suraj Upadhyay wrote: > > Simplify while loops into more readable and simple for loops. > > > > I don't think either is more clear that the other. Walter Harms hates > count down loops and