Re: [PATCH 4/8] drm/sched: Add generic scheduler message interface

2023-08-09 Thread Matthew Brost
On Tue, Aug 08, 2023 at 04:14:55PM +0200, Christian König wrote: > Am 08.08.23 um 16:06 schrieb Matthew Brost: > > [SNIP] > > > Basically workqueues are the in kernel infrastructure for exactly that use > > > case and we are trying to re-create that here and that is usually a rather > > > bad idea.

Re: [PATCH 4/8] drm/sched: Add generic scheduler message interface

2023-08-08 Thread Christian König
Am 08.08.23 um 16:06 schrieb Matthew Brost: [SNIP] Basically workqueues are the in kernel infrastructure for exactly that use case and we are trying to re-create that here and that is usually a rather bad idea. Ok let me play around with what this would look like in Xe, what you are suggesting

Re: [PATCH 4/8] drm/sched: Add generic scheduler message interface

2023-08-08 Thread Matthew Brost
On Mon, Aug 07, 2023 at 05:46:16PM +0200, Christian König wrote: > Am 04.08.23 um 16:13 schrieb Matthew Brost: > > [SNIP] > > Christian / Daniel - I've read both of you comments and having a hard > > time parsing them. I do not really understand the issue with this patch > > or exactly what is bein

Re: [PATCH 4/8] drm/sched: Add generic scheduler message interface

2023-08-07 Thread Christian König
Am 04.08.23 um 16:13 schrieb Matthew Brost: [SNIP] Christian / Daniel - I've read both of you comments and having a hard time parsing them. I do not really understand the issue with this patch or exactly what is being suggested instead. Let's try to work through this. I'm still extremely frowne

Re: [PATCH 4/8] drm/sched: Add generic scheduler message interface

2023-08-04 Thread Matthew Brost
On Fri, Aug 04, 2023 at 10:50:36AM +0200, Daniel Vetter wrote: > On Thu, Aug 03, 2023 at 11:35:30AM +0200, Christian König wrote: > > Am 03.08.23 um 10:58 schrieb Daniel Vetter: > > > On Thu, 3 Aug 2023 at 10:53, Christian König > > > wrote: > > > > Am 01.08.23 um 22:50 schrieb Matthew Brost: > >

Re: [PATCH 4/8] drm/sched: Add generic scheduler message interface

2023-08-04 Thread Daniel Vetter
On Thu, Aug 03, 2023 at 11:35:30AM +0200, Christian König wrote: > Am 03.08.23 um 10:58 schrieb Daniel Vetter: > > On Thu, 3 Aug 2023 at 10:53, Christian König > > wrote: > > > Am 01.08.23 um 22:50 schrieb Matthew Brost: > > > > Add generic schedule message interface which sends messages to backe

Re: [PATCH 4/8] drm/sched: Add generic scheduler message interface

2023-08-03 Thread Christian König
Am 03.08.23 um 10:58 schrieb Daniel Vetter: On Thu, 3 Aug 2023 at 10:53, Christian König wrote: Am 01.08.23 um 22:50 schrieb Matthew Brost: Add generic schedule message interface which sends messages to backend from the drm_gpu_scheduler main submission thread. The idea is some of these messag

Re: [PATCH 4/8] drm/sched: Add generic scheduler message interface

2023-08-03 Thread Daniel Vetter
On Thu, 3 Aug 2023 at 10:53, Christian König wrote: > > Am 01.08.23 um 22:50 schrieb Matthew Brost: > > Add generic schedule message interface which sends messages to backend > > from the drm_gpu_scheduler main submission thread. The idea is some of > > these messages modify some state in drm_sche

Re: [PATCH 4/8] drm/sched: Add generic scheduler message interface

2023-08-03 Thread Christian König
Am 01.08.23 um 22:50 schrieb Matthew Brost: Add generic schedule message interface which sends messages to backend from the drm_gpu_scheduler main submission thread. The idea is some of these messages modify some state in drm_sched_entity which is also modified during submission. By scheduling th

[PATCH 4/8] drm/sched: Add generic scheduler message interface

2023-08-01 Thread Matthew Brost
Add generic schedule message interface which sends messages to backend from the drm_gpu_scheduler main submission thread. The idea is some of these messages modify some state in drm_sched_entity which is also modified during submission. By scheduling these messages and submission in the same thread