Re: [PATCH 5/6] drm/mediatek: Convert to use CMA helpers

2019-12-16 Thread Laurent Pinchart
Hi Rob, On Thu, Oct 24, 2019 at 03:02:57PM +0800, CK Hu wrote: > On Wed, 2019-10-23 at 17:56 -0500, Rob Herring wrote: > > On Wed, Oct 23, 2019 at 4:06 PM CK Hu wrote: > > > On Wed, 2019-10-23 at 12:42 -0500, Rob Herring wrote: > > > > On Tue, Oct 22, 2019 at 12:07 PM Matthias Brugger wrote: > >

Re: [PATCH 5/6] drm/mediatek: Convert to use CMA helpers

2019-10-24 Thread CK Hu
Hi, Rob: On Wed, 2019-10-23 at 17:56 -0500, Rob Herring wrote: > On Wed, Oct 23, 2019 at 4:06 PM CK Hu wrote: > > > > Hi, Rob: > > > > On Wed, 2019-10-23 at 12:42 -0500, Rob Herring wrote: > > > On Tue, Oct 22, 2019 at 12:07 PM Matthias Brugger > > > wrote: > > > > > > > > Hi Rob, > > > > > > >

Re: [PATCH 5/6] drm/mediatek: Convert to use CMA helpers

2019-10-23 Thread Rob Herring
On Wed, Oct 23, 2019 at 4:06 PM CK Hu wrote: > > Hi, Rob: > > On Wed, 2019-10-23 at 12:42 -0500, Rob Herring wrote: > > On Tue, Oct 22, 2019 at 12:07 PM Matthias Brugger > > wrote: > > > > > > Hi Rob, > > > > > > On 21/10/2019 23:45, Rob Herring wrote: > > > > The only reason the Mediatek driver

Re: [PATCH 5/6] drm/mediatek: Convert to use CMA helpers

2019-10-23 Thread CK Hu
Hi, Rob: On Wed, 2019-10-23 at 12:42 -0500, Rob Herring wrote: > On Tue, Oct 22, 2019 at 12:07 PM Matthias Brugger > wrote: > > > > Hi Rob, > > > > On 21/10/2019 23:45, Rob Herring wrote: > > > The only reason the Mediatek driver doesn't use the CMA helpers is it > > > sets

Re: [PATCH 5/6] drm/mediatek: Convert to use CMA helpers

2019-10-23 Thread Rob Herring
On Tue, Oct 22, 2019 at 12:07 PM Matthias Brugger wrote: > > Hi Rob, > > On 21/10/2019 23:45, Rob Herring wrote: > > The only reason the Mediatek driver doesn't use the CMA helpers is it > > sets DMA_ATTR_NO_KERNEL_MAPPING and does a vmap() on demand. Using > > vmap() is not even guaranteed to

Re: [PATCH 5/6] drm/mediatek: Convert to use CMA helpers

2019-10-22 Thread Matthias Brugger
Hi Rob, On 21/10/2019 23:45, Rob Herring wrote: > The only reason the Mediatek driver doesn't use the CMA helpers is it > sets DMA_ATTR_NO_KERNEL_MAPPING and does a vmap() on demand. Using > vmap() is not even guaranteed to work as DMA buffers may not have a > struct page. Now that the CMA

[PATCH 5/6] drm/mediatek: Convert to use CMA helpers

2019-10-21 Thread Rob Herring
The only reason the Mediatek driver doesn't use the CMA helpers is it sets DMA_ATTR_NO_KERNEL_MAPPING and does a vmap() on demand. Using vmap() is not even guaranteed to work as DMA buffers may not have a struct page. Now that the CMA helpers support setting DMA_ATTR_NO_KERNEL_MAPPING as needed or