Re: [PATCH 5/6] soc: qcom: add OCMEM driver

2019-06-17 Thread Rob Clark
On Mon, Jun 17, 2019 at 7:02 PM Brian Masney wrote: > > Hi Rob Clark, > > On Sun, Jun 16, 2019 at 10:41:06AM -0700, Bjorn Andersson wrote: > > > diff --git a/drivers/soc/qcom/ocmem.xml.h b/drivers/soc/qcom/ocmem.xml.h > > > > I would prefer that these lived at the top of the c file, rather than >

Re: [PATCH 5/6] soc: qcom: add OCMEM driver

2019-06-17 Thread Brian Masney
Hi Rob Clark, On Sun, Jun 16, 2019 at 10:41:06AM -0700, Bjorn Andersson wrote: > > diff --git a/drivers/soc/qcom/ocmem.xml.h b/drivers/soc/qcom/ocmem.xml.h > > I would prefer that these lived at the top of the c file, rather than > being generated. I think it would be nice to make this change

Re: [PATCH 5/6] soc: qcom: add OCMEM driver

2019-06-16 Thread Bjorn Andersson
On Sun 16 Jun 06:29 PDT 2019, Brian Masney wrote: > From: Rob Clark > > The OCMEM driver handles allocation and configuration of the On Chip > MEMory that is present on some Snapdragon SoCs. > > Devices which have OCMEM do not have GMEM inside the GPU core, so the > GPU must instead use OCMEM

[PATCH 5/6] soc: qcom: add OCMEM driver

2019-06-16 Thread Brian Masney
From: Rob Clark The OCMEM driver handles allocation and configuration of the On Chip MEMory that is present on some Snapdragon SoCs. Devices which have OCMEM do not have GMEM inside the GPU core, so the GPU must instead use OCMEM to be functional. Since currently the GPU is the only OCMEM user