[PATCH 6/6] drm/gma500: use common functions for get/put pages

2011-09-12 Thread Alan Cox
> > 3. GMA500 used the old way of doing things because last mail conversation > > I had with Hugh the cleaned up interfaces could not guarantee the page is > > mapped in the low 32bits and for any of the GMA500/600 series devices. > > > > Has that changed ? I think I'd also prefer it if the methods

[PATCH 6/6] drm/gma500: use common functions for get/put pages

2011-09-12 Thread Alan Cox
On Mon, 12 Sep 2011 14:21:26 -0500 Rob Clark wrote: > From: Rob Clark > > Signed-off-by: Rob Clark Generally looks sensible but: 1. This is a staging driver, so good practise is to cc the staging maintainer and preferably the author (though I'm on dri-devel so its ok). It needs to be co-ordi

[PATCH 6/6] drm/gma500: use common functions for get/put pages

2011-09-12 Thread Rob Clark
On Mon, Sep 12, 2011 at 3:31 PM, Alan Cox wrote: > On Mon, 12 Sep 2011 14:21:26 -0500 > Rob Clark wrote: > >> From: Rob Clark >> >> Signed-off-by: Rob Clark > > Generally looks sensible but: > > 1. This is a staging driver, so good practise is to cc the staging > maintainer and preferably the a

Re: [PATCH 6/6] drm/gma500: use common functions for get/put pages

2011-09-12 Thread Alan Cox
> > 3. GMA500 used the old way of doing things because last mail conversation > > I had with Hugh the cleaned up interfaces could not guarantee the page is > > mapped in the low 32bits and for any of the GMA500/600 series devices. > > > > Has that changed ? I think I'd also prefer it if the methods

Re: [PATCH 6/6] drm/gma500: use common functions for get/put pages

2011-09-12 Thread Rob Clark
On Mon, Sep 12, 2011 at 3:31 PM, Alan Cox wrote: > On Mon, 12 Sep 2011 14:21:26 -0500 > Rob Clark wrote: > >> From: Rob Clark >> >> Signed-off-by: Rob Clark > > Generally looks sensible but: > > 1. This is a staging driver, so good practise is to cc the staging > maintainer and preferably the a

[PATCH 6/6] drm/gma500: use common functions for get/put pages

2011-09-12 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- drivers/staging/gma500/gtt.c | 47 ++--- 1 files changed, 12 insertions(+), 35 deletions(-) diff --git a/drivers/staging/gma500/gtt.c b/drivers/staging/gma500/gtt.c index 461ead2..f453321 100644 --- a/drivers/st

Re: [PATCH 6/6] drm/gma500: use common functions for get/put pages

2011-09-12 Thread Alan Cox
On Mon, 12 Sep 2011 14:21:26 -0500 Rob Clark wrote: > From: Rob Clark > > Signed-off-by: Rob Clark Generally looks sensible but: 1. This is a staging driver, so good practise is to cc the staging maintainer and preferably the author (though I'm on dri-devel so its ok). It needs to be co-ordi

[PATCH 6/6] drm/gma500: use common functions for get/put pages

2011-09-12 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- drivers/staging/gma500/gtt.c | 47 ++--- 1 files changed, 12 insertions(+), 35 deletions(-) diff --git a/drivers/staging/gma500/gtt.c b/drivers/staging/gma500/gtt.c index 461ead2..f453321 100644 --- a/drivers/st