Re: [PATCH 6/6] drm/rockchip: fix race with kms hotplug and fbdev

2017-07-31 Thread Mark yao
On 2017年07月31日 20:28, Daniel Vetter wrote: On Mon, Jul 31, 2017 at 1:57 PM, Emil Velikov wrote: On 31 July 2017 at 10:50, Mark Yao wrote: Since fb_helper is not a pointer on rockchip_drm_private, it's no need to check pointer. Kms hotplug

Re: [PATCH 6/6] drm/rockchip: fix race with kms hotplug and fbdev

2017-07-31 Thread Daniel Vetter
On Mon, Jul 31, 2017 at 1:57 PM, Emil Velikov wrote: > On 31 July 2017 at 10:50, Mark Yao wrote: >> Since fb_helper is not a pointer on rockchip_drm_private, it's no >> need to check pointer. >> >> Kms hotplug event may race into fbdev helper

Re: [PATCH 6/6] drm/rockchip: fix race with kms hotplug and fbdev

2017-07-31 Thread Emil Velikov
On 31 July 2017 at 10:50, Mark Yao wrote: > Since fb_helper is not a pointer on rockchip_drm_private, it's no > need to check pointer. > > Kms hotplug event may race into fbdev helper initial, and fb_helper->dev > may be NULL pointer, that would cause the bug: > > [

[PATCH 6/6] drm/rockchip: fix race with kms hotplug and fbdev

2017-07-31 Thread Mark Yao
Since fb_helper is not a pointer on rockchip_drm_private, it's no need to check pointer. Kms hotplug event may race into fbdev helper initial, and fb_helper->dev may be NULL pointer, that would cause the bug: [0.735411] [0200] *pgd=f6ffe003, *pud=f6ffe003,