Re: [PATCH 9/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-07-30 Thread Jagan Teki
On Wed, Jul 19, 2023 at 2:05 PM Ying Liu wrote: > > On Tuesday, July 18, 2023 6:51 PM Jagan Teki > wrote: > > > > Hi, > > Hi, > > > > > On Tue, Jul 18, 2023 at 3:19 PM Ying Liu wrote: > > > > > > On Tuesday, July 18, 2023 5:35 PM Jagan Teki > > wrote: > > > > > > > > > > > > > > Hi Jagan, > >

RE: [PATCH 9/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-07-19 Thread Ying Liu
On Tuesday, July 18, 2023 11:47 PM Sam Ravnborg wrote: > > Hi Ying Liu, Hi Sam, > > On Tue, Jul 18, 2023 at 09:00:25AM +, Ying Liu wrote: > > > > + if (IS_ERR(dsi->regmap)) { > > > > + ret = PTR_ERR(dsi->regmap); > > > > + DRM_DEV_ERROR(dev, "failed to get block ctrl

RE: [PATCH 9/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-07-19 Thread Ying Liu
On Tuesday, July 18, 2023 6:51 PM Jagan Teki wrote: > > Hi, Hi, > > On Tue, Jul 18, 2023 at 3:19 PM Ying Liu wrote: > > > > On Tuesday, July 18, 2023 5:35 PM Jagan Teki > wrote: > > > > > > > > > > > Hi Jagan, > > > > > > > > On Monday, July 17, 2023 2:44 PM Jagan Teki > > > wrote: > > > >

Re: [PATCH 9/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-07-18 Thread kernel test robot
drm-bridge-synopsys-dw-mipi-dsi-Add-dw_mipi_dsi_get_bridge-helper/20230718-172247 base: https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git exynos-drm-next patch link: https://lore.kernel.org/r/20230717061831.1826878-10-victor.liu%40nxp.com patch subject: [PATCH 9/9] drm/bridge

Re: [PATCH 9/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-07-18 Thread Sam Ravnborg
Hi Ying Liu, On Tue, Jul 18, 2023 at 09:00:25AM +, Ying Liu wrote: > > > + if (IS_ERR(dsi->regmap)) { > > > + ret = PTR_ERR(dsi->regmap); > > > + DRM_DEV_ERROR(dev, "failed to get block ctrl regmap: > > %d\n", ret); > > > > Could you use dev_err_probe here instead? > > M

Re: [PATCH 9/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-07-18 Thread Jagan Teki
Hi, On Tue, Jul 18, 2023 at 3:19 PM Ying Liu wrote: > > On Tuesday, July 18, 2023 5:35 PM Jagan Teki > wrote: > > > > > > > > Hi Jagan, > > > > > > On Monday, July 17, 2023 2:44 PM Jagan Teki > > wrote: > > > > On Mon, Jul 17, 2023 at 11:44 AM Liu Ying wrote: > > > > > > > > > > Freescale i.M

RE: [PATCH 9/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-07-18 Thread Ying Liu
On Tuesday, July 18, 2023 5:31 PM Alexander Stein wrote: > > Hi, Hi, > > Am Dienstag, 18. Juli 2023, 11:00:25 CEST schrieb Ying Liu: > > On Tuesday, July 18, 2023 3:49 PM Alexander Stein > group.com> wrote: > > > Hi, > > > > Hi, > > > > > thanks for the patch. > > > > Thanks for your review. >

RE: [PATCH 9/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-07-18 Thread Ying Liu
On Tuesday, July 18, 2023 5:35 PM Jagan Teki wrote: > > > > > Hi Jagan, > > > > On Monday, July 17, 2023 2:44 PM Jagan Teki > wrote: > > > On Mon, Jul 17, 2023 at 11:44 AM Liu Ying wrote: > > > > > > > > Freescale i.MX93 SoC embeds a Synopsys Designware MIPI DSI host > > > > controller and a Sy

Re: [PATCH 9/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-07-18 Thread Jagan Teki
On Tue, Jul 18, 2023 at 8:28 AM Ying Liu wrote: > > Hi Jagan, > > On Monday, July 17, 2023 2:44 PM Jagan Teki > wrote: > > On Mon, Jul 17, 2023 at 11:44 AM Liu Ying wrote: > > > > > > Freescale i.MX93 SoC embeds a Synopsys Designware MIPI DSI host > > > controller and a Synopsys Designware MIPI

Re: [PATCH 9/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-07-18 Thread Alexander Stein
Hi, Am Dienstag, 18. Juli 2023, 11:00:25 CEST schrieb Ying Liu: > On Tuesday, July 18, 2023 3:49 PM Alexander Stein wrote: > > Hi, > > Hi, > > > thanks for the patch. > > Thanks for your review. > > > Am Montag, 17. Juli 2023, 08:18:31 CEST schrieb Liu Ying: > > > Freescale i.MX93 SoC embeds

RE: [PATCH 9/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-07-18 Thread Ying Liu
On Tuesday, July 18, 2023 3:49 PM Alexander Stein wrote: > > Hi, Hi, > > thanks for the patch. Thanks for your review. > > Am Montag, 17. Juli 2023, 08:18:31 CEST schrieb Liu Ying: > > Freescale i.MX93 SoC embeds a Synopsys Designware MIPI DSI host > > controller and a Synopsys Designware MIP

Re: [PATCH 9/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-07-18 Thread Alexander Stein
Hi, thanks for the patch. Am Montag, 17. Juli 2023, 08:18:31 CEST schrieb Liu Ying: > Freescale i.MX93 SoC embeds a Synopsys Designware MIPI DSI host > controller and a Synopsys Designware MIPI DPHY. Some configurations > and extensions to them are controlled by i.MX93 media blk-ctrl. > > Add a

RE: [PATCH 9/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-07-17 Thread Ying Liu
Hi Jagan, On Monday, July 17, 2023 2:44 PM Jagan Teki wrote: > On Mon, Jul 17, 2023 at 11:44 AM Liu Ying wrote: > > > > Freescale i.MX93 SoC embeds a Synopsys Designware MIPI DSI host > > controller and a Synopsys Designware MIPI DPHY. Some configurations > > and extensions to them are controll

Re: [PATCH 9/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-07-16 Thread Jagan Teki
On Mon, Jul 17, 2023 at 11:44 AM Liu Ying wrote: > > Freescale i.MX93 SoC embeds a Synopsys Designware MIPI DSI host > controller and a Synopsys Designware MIPI DPHY. Some configurations > and extensions to them are controlled by i.MX93 media blk-ctrl. > > Add a DRM bridge for i.MX93 MIPI DSI by

[PATCH 9/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-07-16 Thread Liu Ying
Freescale i.MX93 SoC embeds a Synopsys Designware MIPI DSI host controller and a Synopsys Designware MIPI DPHY. Some configurations and extensions to them are controlled by i.MX93 media blk-ctrl. Add a DRM bridge for i.MX93 MIPI DSI by using existing DW MIPI DSI bridge helpers and implementing i.