[Intel-gfx] [PATCH 9/9] drm/i915: Disable eDP VDD in a delayed work proc instead of synchronously

2011-09-23 Thread Jesse Barnes
On Tue, 20 Sep 2011 21:51:33 -0700 Keith Packard wrote: > Yes, making it cleaner would help a ton. There are some basic problems > with the DRM API that make this hard though -- intel_dp_prepare may > not ever be followed by a call to intel_dp_commit. That's why I had > the VDD AUX stuff get

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Disable eDP VDD in a delayed work proc instead of synchronously

2011-09-22 Thread Jesse Barnes
On Tue, 20 Sep 2011 21:51:33 -0700 Keith Packard kei...@keithp.com wrote: Yes, making it cleaner would help a ton. There are some basic problems with the DRM API that make this hard though -- intel_dp_prepare may not ever be followed by a call to intel_dp_commit. That's why I had the VDD AUX

[Intel-gfx] [PATCH 9/9] drm/i915: Disable eDP VDD in a delayed work proc instead of synchronously

2011-09-21 Thread Jesse Barnes
On Mon, 19 Sep 2011 15:22:03 -0700 Keith Packard wrote: > There's no good reason to turn off the eDP force VDD bit synchronously > while probing devices; that just sticks a huge delay into all mode > setting paths. Instead, queue a delayed work proc to disable the VDD > force bit and then

[Intel-gfx] [PATCH 9/9] drm/i915: Disable eDP VDD in a delayed work proc instead of synchronously

2011-09-20 Thread Keith Packard
On Wed, 21 Sep 2011 09:47:59 +0530, Jesse Barnes wrote: > I'm worried this makes our PPS even more complex and hard to follow. > I'd rather see VDD AUX applied only when we need it (dpms, mode set and > detect; for hotplug we can assume the panel is alive) and that we > carefully disable it

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Disable eDP VDD in a delayed work proc instead of synchronously

2011-09-20 Thread Jesse Barnes
On Mon, 19 Sep 2011 15:22:03 -0700 Keith Packard kei...@keithp.com wrote: There's no good reason to turn off the eDP force VDD bit synchronously while probing devices; that just sticks a huge delay into all mode setting paths. Instead, queue a delayed work proc to disable the VDD force bit

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Disable eDP VDD in a delayed work proc instead of synchronously

2011-09-20 Thread Keith Packard
On Wed, 21 Sep 2011 09:47:59 +0530, Jesse Barnes jbar...@virtuousgeek.org wrote: I'm worried this makes our PPS even more complex and hard to follow. I'd rather see VDD AUX applied only when we need it (dpms, mode set and detect; for hotplug we can assume the panel is alive) and that we

[PATCH 9/9] drm/i915: Disable eDP VDD in a delayed work proc instead of synchronously

2011-09-19 Thread Keith Packard
There's no good reason to turn off the eDP force VDD bit synchronously while probing devices; that just sticks a huge delay into all mode setting paths. Instead, queue a delayed work proc to disable the VDD force bit and then remember when that fires to ensure that the appropriate delay is

[PATCH 9/9] drm/i915: Disable eDP VDD in a delayed work proc instead of synchronously

2011-09-19 Thread Keith Packard
There's no good reason to turn off the eDP force VDD bit synchronously while probing devices; that just sticks a huge delay into all mode setting paths. Instead, queue a delayed work proc to disable the VDD force bit and then remember when that fires to ensure that the appropriate delay is