On Thu, Nov 19, 2015 at 04:50:11PM +, Daniel Stone wrote:
> Hi,
>
> On 19 November 2015 at 16:46, Daniel Vetter wrote:
> > @@ -367,7 +364,6 @@ int exynos_drm_gem_get_ioctl(struct drm_device *dev,
> > void *data,
> > args->size = exynos_gem->size;
> >
> >
The only things this protects is reading ->flags and ->size, both of
which are invariant over the lifetime of an exynos gem bo. So no
locking needed at all (besides that, nothing protects the writers
anyway).
Aside: exynos_gem_obj->size is redundant with
exynos_gem_obj->base.size and probably
Hi,
On 19 November 2015 at 16:46, Daniel Vetter wrote:
> @@ -367,7 +364,6 @@ int exynos_drm_gem_get_ioctl(struct drm_device *dev, void
> *data,
> args->size = exynos_gem->size;
>
> drm_gem_object_unreference(obj);
> - mutex_unlock(>struct_mutex);
