Re: [PATCH RFC 1/3] drm/i2c: tda998x: implement different I2S flavours

2019-02-26 Thread Sven Van Asbroeck
On Fri, Feb 22, 2019 at 4:27 PM Russell King wrote: > > Add support for the left and right justified I2S formats as well as the > more tranditional "Philips" I2S format. > > Signed-off-by: Russell King My imx6q ssi has i2s and left-justified in common with the tda998x. Left justified does not

Re: [PATCH RFC 1/3] drm/i2c: tda998x: implement different I2S flavours

2019-02-25 Thread Russell King - ARM Linux admin
On Mon, Feb 25, 2019 at 03:28:51PM +0200, Peter Ujfalusi wrote: > hi Russell, > > On 22/02/2019 23.27, Russell King wrote: > > Add support for the left and right justified I2S formats as well as the > > more tranditional "Philips" I2S format. > > First of all, thank you for the patch, it works.

Re: [PATCH RFC 1/3] drm/i2c: tda998x: implement different I2S flavours

2019-02-25 Thread Peter Ujfalusi
hi Russell, On 22/02/2019 23.27, Russell King wrote: > Add support for the left and right justified I2S formats as well as the > more tranditional "Philips" I2S format. First of all, thank you for the patch, it works. Tested-by: Peter Ujfalusi There is however one thing I'm not sure about.

Re: [PATCH RFC 1/3] drm/i2c: tda998x: implement different I2S flavours

2019-02-25 Thread Jyri Sarha
On 22/02/2019 23:27, Russell King wrote: > Add support for the left and right justified I2S formats as well as the > more tranditional "Philips" I2S format. > > Signed-off-by: Russell King I do not have a spec to check REG_I2S_FORMAT bits, but at least philips and left justified formats work on

[PATCH RFC 1/3] drm/i2c: tda998x: implement different I2S flavours

2019-02-25 Thread Russell King
Add support for the left and right justified I2S formats as well as the more tranditional "Philips" I2S format. Signed-off-by: Russell King --- drivers/gpu/drm/i2c/tda998x_drv.c | 57 ++- include/drm/i2c/tda998x.h | 11 +--- 2 files changed, 47