Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-22 Thread Byungchul Park
On Thu, May 19, 2022 at 11:11:10AM +0100, Catalin Marinas wrote: > On Wed, May 11, 2022 at 07:04:51PM +0900, Hyeonggon Yoo wrote: > > On Wed, May 11, 2022 at 08:39:29AM +0900, Byungchul Park wrote: > > > On Tue, May 10, 2022 at 08:18:12PM +0900, Hyeonggon Yoo wrote: > > > > On Mon, May 09, 2022 at

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-20 Thread Catalin Marinas
On Wed, May 11, 2022 at 07:04:51PM +0900, Hyeonggon Yoo wrote: > On Wed, May 11, 2022 at 08:39:29AM +0900, Byungchul Park wrote: > > On Tue, May 10, 2022 at 08:18:12PM +0900, Hyeonggon Yoo wrote: > > > On Mon, May 09, 2022 at 09:16:37AM +0900, Byungchul Park wrote: > > > > CASE 1. > > > > > > > >

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-11 Thread Hyeonggon Yoo
On Wed, May 11, 2022 at 08:39:29AM +0900, Byungchul Park wrote: > On Tue, May 10, 2022 at 08:18:12PM +0900, Hyeonggon Yoo wrote: > > On Mon, May 09, 2022 at 09:16:37AM +0900, Byungchul Park wrote: > > > On Sat, May 07, 2022 at 04:20:50PM +0900, Hyeonggon Yoo wrote: > > > > On Fri, May 06, 2022 at

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-10 Thread Byungchul Park
On Tue, May 10, 2022 at 02:37:40PM +0900, Byungchul Park wrote: > Ted wrote: > > On Tue, May 10, 2022 at 09:32:13AM +0900, Byungchul Park wrote: > > > DEPT is tracking way more objects than Lockdep so it's inevitable to be > > > slower, but let me try to make it have the similar performance to > >

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-10 Thread Byungchul Park
On Tue, May 10, 2022 at 08:18:12PM +0900, Hyeonggon Yoo wrote: > On Mon, May 09, 2022 at 09:16:37AM +0900, Byungchul Park wrote: > > On Sat, May 07, 2022 at 04:20:50PM +0900, Hyeonggon Yoo wrote: > > > On Fri, May 06, 2022 at 09:11:35AM +0900, Byungchul Park wrote: > > > > Linus wrote: > > > > > >

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-10 Thread Byungchul Park
On Tue, May 10, 2022 at 10:12:54AM -0400, Steven Rostedt wrote: > On Tue, 10 May 2022 08:38:38 +0900 > Byungchul Park wrote: > > > Yes, I was talking about A and L'. > > > > > detect that regardless of L. A nested lock associates the the nesting > > > with > > > > When I checked Lockdep

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-10 Thread Steven Rostedt
On Tue, 10 May 2022 08:38:38 +0900 Byungchul Park wrote: > Yes, I was talking about A and L'. > > > detect that regardless of L. A nested lock associates the the nesting with > > When I checked Lockdep code, L' with depth n + 1 and L' with depth n > have different classes in Lockdep. If

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-10 Thread Hyeonggon Yoo
On Mon, May 09, 2022 at 09:16:37AM +0900, Byungchul Park wrote: > On Sat, May 07, 2022 at 04:20:50PM +0900, Hyeonggon Yoo wrote: > > On Fri, May 06, 2022 at 09:11:35AM +0900, Byungchul Park wrote: > > > Linus wrote: > > > > > > > > On Wed, May 4, 2022 at 1:19 AM Byungchul Park > > > > wrote: > >

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-09 Thread Byungchul Park
Ted wrote: > On Tue, May 10, 2022 at 09:32:13AM +0900, Byungchul Park wrote: > > Yes, right. DEPT has never been optimized. It rather turns on > > CONFIG_LOCKDEP and even CONFIG_PROVE_LOCKING when CONFIG_DEPT gets on > > because of porting issue. I have no choice but to rely on those to > >

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-09 Thread Theodore Ts'o
On Tue, May 10, 2022 at 09:32:13AM +0900, Byungchul Park wrote: > Yes, right. DEPT has never been optimized. It rather turns on > CONFIG_LOCKDEP and even CONFIG_PROVE_LOCKING when CONFIG_DEPT gets on > because of porting issue. I have no choice but to rely on those to > develop DEPT out of tree.

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-09 Thread Byungchul Park
On Mon, May 09, 2022 at 06:28:17PM -0400, Theodore Ts'o wrote: > Oh, one other problem with DEPT --- it's SLOW --- the overhead is > enormous. Using kvm-xfstests[1] running "kvm-xfstests smoke", here > are some sample times: Yes, right. DEPT has never been optimized. It rather turns on

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-09 Thread Byungchul Park
On Mon, May 09, 2022 at 04:47:12PM -0400, Steven Rostedt wrote: > On Mon, 9 May 2022 09:16:37 +0900 > Byungchul Park wrote: > > > CASE 2. > > > >lock L with depth n > >lock A > >lock_nested L' with depth n + 1 > >... > >unlock L' > >unlock A > >unlock L > > > > This

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-09 Thread Theodore Ts'o
Oh, one other problem with DEPT --- it's SLOW --- the overhead is enormous. Using kvm-xfstests[1] running "kvm-xfstests smoke", here are some sample times: LOCKDEP DEPT Time to first test 49 seconds 602 seconds ext4/0012 s 22

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-09 Thread Theodore Ts'o
I tried DEPT-v6 applied against 5.18-rc5, and it reported the following positive. The reason why it's nonsense is that in context A's [W] wait: [ 1538.545054] [W] folio_wait_bit_common(pglocked:0): [ 1538.545370] [] __filemap_get_folio+0x3e4/0x420 [ 1538.545763] stacktrace: [ 1538.545928]

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-09 Thread Steven Rostedt
On Mon, 9 May 2022 09:16:37 +0900 Byungchul Park wrote: > CASE 2. > >lock L with depth n >lock A >lock_nested L' with depth n + 1 >... >unlock L' >unlock A >unlock L > > This case is allowed by Lockdep. > This case is *NOT* allowed by DEPT cuz it's a *DEADLOCK*. >

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-08 Thread Byungchul Park
On Wed, May 04, 2022 at 11:17:02AM -0700, Linus Torvalds wrote: > On Wed, May 4, 2022 at 1:19 AM Byungchul Park wrote: > > > > Hi Linus and folks, > > > > I've been developing a tool for detecting deadlock possibilities by > > tracking wait/event rather than lock(?) acquisition order to try to >

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-08 Thread Byungchul Park
On Sat, May 07, 2022 at 04:20:50PM +0900, Hyeonggon Yoo wrote: > On Fri, May 06, 2022 at 09:11:35AM +0900, Byungchul Park wrote: > > Linus wrote: > > > > > > On Wed, May 4, 2022 at 1:19 AM Byungchul Park > > > wrote: > > > > > > > > Hi Linus and folks, > > > > > > > > I've been developing a tool

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-07 Thread Hyeonggon Yoo
On Fri, May 06, 2022 at 09:11:35AM +0900, Byungchul Park wrote: > Linus wrote: > > > > On Wed, May 4, 2022 at 1:19 AM Byungchul Park > > wrote: > > > > > > Hi Linus and folks, > > > > > > I've been developing a tool for detecting deadlock possibilities by > > > tracking wait/event rather than

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-05 Thread Byungchul Park
Linus wrote: > > On Wed, May 4, 2022 at 1:19 AM Byungchul Park wrote: > > > > Hi Linus and folks, > > > > I've been developing a tool for detecting deadlock possibilities by > > tracking wait/event rather than lock(?) acquisition order to try to > > cover all synchonization machanisms. > > So

Re: [PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-04 Thread Linus Torvalds
On Wed, May 4, 2022 at 1:19 AM Byungchul Park wrote: > > Hi Linus and folks, > > I've been developing a tool for detecting deadlock possibilities by > tracking wait/event rather than lock(?) acquisition order to try to > cover all synchonization machanisms. So what is the actual status of

[PATCH RFC v6 00/21] DEPT(Dependency Tracker)

2022-05-04 Thread Byungchul Park
Hi Linus and folks, I've been developing a tool for detecting deadlock possibilities by tracking wait/event rather than lock(?) acquisition order to try to cover all synchonization machanisms. It's done on v5.18-rc3 tag.