Re: [PATCH V2] dmabuf: ensure unique directory name for dmabuf stats

2022-05-12 Thread Charan Teja Kalla
Thanks Christian for the comments!! On 5/11/2022 12:33 PM, Christian König wrote: > >> The single number approach, generated by atomic, wouldn't break the >> uapi, but that number won't give any meaningful information especially >> when this is targeted just for debug purpose. And just 'inode'

Re: [PATCH V2] dmabuf: ensure unique directory name for dmabuf stats

2022-05-11 Thread Christian König
Am 11.05.22 um 08:49 schrieb Charan Teja Kalla: Thanks Christian for the inputs!! On 5/10/2022 10:52 PM, Christian König wrote:      if (!dmabuf || !dmabuf->file)    return -EINVAL; @@ -192,7 +193,8 @@ int dma_buf_stats_setup(struct dma_buf *dmabuf)      /* create the

Re: [PATCH V2] dmabuf: ensure unique directory name for dmabuf stats

2022-05-11 Thread Charan Teja Kalla
Thanks Christian for the inputs!! On 5/10/2022 10:52 PM, Christian König wrote:      if (!dmabuf || !dmabuf->file)    return -EINVAL; @@ -192,7 +193,8 @@ int dma_buf_stats_setup(struct dma_buf *dmabuf)      /* create the directory for buffer stats */   

Re: [PATCH V2] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread kernel test robot
Hi Charan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.18-rc6 next-20220510] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as

Re: [PATCH V2] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Christian König
Am 10.05.22 um 19:14 schrieb Charan Teja Kalla: On 5/10/2022 8:42 PM, Christian König wrote:    * The information in the interface can also be used to derive per-exporter    * statistics. The data from the interface can be gathered on error conditions @@ -172,6 +172,7 @@ int

Re: [PATCH V2] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Charan Teja Kalla
On 5/10/2022 8:42 PM, Christian König wrote: >>    * The information in the interface can also be used to derive >> per-exporter >>    * statistics. The data from the interface can be gathered on error >> conditions >> @@ -172,6 +172,7 @@ int dma_buf_stats_setup(struct dma_buf *dmabuf) >>   { >>   

Re: [PATCH V2] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Christian König
Am 10.05.22 um 16:06 schrieb Charan Teja Kalla: The dmabuf file uses get_next_ino()(through dma_buf_getfile() -> alloc_anon_inode()) to get an inode number and uses the same as a directory name under /sys/kernel/dmabuf/buffers/. This directory is used to collect the dmabuf stats and it is

[PATCH V2] dmabuf: ensure unique directory name for dmabuf stats

2022-05-10 Thread Charan Teja Kalla
The dmabuf file uses get_next_ino()(through dma_buf_getfile() -> alloc_anon_inode()) to get an inode number and uses the same as a directory name under /sys/kernel/dmabuf/buffers/. This directory is used to collect the dmabuf stats and it is created through dma_buf_stats_setup(). At current,