Re: [PATCH V4] fbcon: fix fbcon out-of-bounds write in sys_imageblit

2021-08-30 Thread Geert Uytterhoeven
Hi Tetsuo, On Mon, Aug 30, 2021 at 12:25 PM Tetsuo Handa wrote: > On 2021/08/30 17:16, Daniel Vetter wrote: > > On Mon, Aug 30, 2021 at 11:30:23AM +0800, tcs.ker...@gmail.com wrote: > >> From: Haimin Zhang > >> > >> yres and vyres can be controlled by user mode parameters, and cause > >>

Re: [PATCH V4] fbcon: fix fbcon out-of-bounds write in sys_imageblit

2021-08-30 Thread Tetsuo Handa
On 2021/08/30 17:16, Daniel Vetter wrote: > On Mon, Aug 30, 2021 at 11:30:23AM +0800, tcs.ker...@gmail.com wrote: >> From: Haimin Zhang >> >> yres and vyres can be controlled by user mode parameters, and cause >> p->vrows to become a negative value. While this value be passed to real_y >>

Re: [PATCH V4] fbcon: fix fbcon out-of-bounds write in sys_imageblit

2021-08-30 Thread Daniel Vetter
On Mon, Aug 30, 2021 at 11:30:23AM +0800, tcs.ker...@gmail.com wrote: > From: Haimin Zhang > > yres and vyres can be controlled by user mode parameters, and cause > p->vrows to become a negative value. While this value be passed to real_y > function, the ypos will be out of screen range.This is

[PATCH V4] fbcon: fix fbcon out-of-bounds write in sys_imageblit

2021-08-30 Thread tcs . kernel
From: Haimin Zhang yres and vyres can be controlled by user mode parameters, and cause p->vrows to become a negative value. While this value be passed to real_y function, the ypos will be out of screen range.This is an out-of-bounds write bug. some driver will check xres and yres in fb_check_var

Re: [PATCH V4] fbcon: fix fbcon out-of-bounds write in sys_imageblit

2021-08-29 Thread Greg KH
On Mon, Aug 30, 2021 at 11:30:23AM +0800, tcs.ker...@gmail.com wrote: > From: Haimin Zhang > > yres and vyres can be controlled by user mode parameters, and cause > p->vrows to become a negative value. While this value be passed to real_y > function, the ypos will be out of screen range.This is