RE: [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Wait for vblank before collecting CRC

2021-05-21 Thread Srinivas, Vidya
-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; igt-...@lists.freedesktop.org Cc: Lin, Charlton Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Wait for vblank before collecting CRC Hi Vidya, on which machines this would help? I see there's many vblanks already being waited. There's

Re: [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Wait for vblank before collecting CRC

2021-05-21 Thread Juha-Pekka Heikkila
Hi Vidya, on which machines this would help? I see there's many vblanks already being waited. There's igt_display_commit2 which probably will block and even if it didn't there's igt_pipe_crc_collect_crc(..) where crc calculation is started after flip and then get one crc before disabling crc

[PATCH i-g-t] tests/kms_big_fb: Wait for vblank before collecting CRC

2021-05-20 Thread Vidya Srinivas
Without wait for vblank, CRC mismatch is seen between big and small CRC on few systems Change-Id: I3bec931aa901130997e693ac1cacf389e2a8100f Signed-off-by: Vidya Srinivas --- tests/kms_big_fb.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/kms_big_fb.c