Re: [PATCH libdrm] xf86drm: Add drmIsMaster()

2019-01-21 Thread Daniel Vetter
On Tue, Jan 22, 2019 at 3:26 AM Christopher James Halse Rogers wrote: > > On 18 December 2018 7:07:01 pm NZDT, Christopher James Halse Rogers > wrote: >> >> On 18 December 2018 4:35:37 am AEDT, Emil Velikov >> wrote: >>> >>> Hi Christopher, >>> >>> On Tue, 20 Nov 2018 at 03:37, Christopher

Re: [PATCH libdrm] xf86drm: Add drmIsMaster()

2019-01-21 Thread Christopher James Halse Rogers
On 18 December 2018 7:07:01 pm NZDT, Christopher James Halse Rogers wrote: >On 18 December 2018 4:35:37 am AEDT, Emil Velikov > wrote: >>Hi Christopher, >> >>On Tue, 20 Nov 2018 at 03:37, Christopher James Halse Rogers >> wrote: >>> >>> We can't use drmSetMaster to query whether or not a drm fd

Re: [PATCH libdrm] xf86drm: Add drmIsMaster()

2018-12-17 Thread Christopher James Halse Rogers
On 18 December 2018 4:35:37 am AEDT, Emil Velikov wrote: >Hi Christopher, > >On Tue, 20 Nov 2018 at 03:37, Christopher James Halse Rogers > wrote: >> >> We can't use drmSetMaster to query whether or not a drm fd is master >> because it requires CAP_SYS_ADMIN, even if the fd *is* a master fd. >>

Re: [PATCH libdrm] xf86drm: Add drmIsMaster()

2018-12-17 Thread Daniel Vetter
On Mon, Dec 17, 2018 at 6:38 PM Emil Velikov wrote: > > Hi Christopher, > > On Tue, 20 Nov 2018 at 03:37, Christopher James Halse Rogers > wrote: > > > > We can't use drmSetMaster to query whether or not a drm fd is master > > because it requires CAP_SYS_ADMIN, even if the fd *is* a master fd. >

Re: [PATCH libdrm] xf86drm: Add drmIsMaster()

2018-12-17 Thread Emil Velikov
Hi Christopher, On Tue, 20 Nov 2018 at 03:37, Christopher James Halse Rogers wrote: > > We can't use drmSetMaster to query whether or not a drm fd is master > because it requires CAP_SYS_ADMIN, even if the fd *is* a master fd. > Can you please mention the exact use case here? You mentioned it

[PATCH libdrm] xf86drm: Add drmIsMaster()

2018-11-19 Thread Christopher James Halse Rogers
We can't use drmSetMaster to query whether or not a drm fd is master because it requires CAP_SYS_ADMIN, even if the fd *is* a master fd. Pick DRM_IOCTL_MODE_ATTACHMODE as a long-deprecated ioctl that is DRM_MASTER but not DRM_ROOT_ONLY as the probe by which we can detect whether or not the fd is