Re: [PATCH libdrm v2] *-symbol-check: Don't hard-code nm executable

2018-02-23 Thread Emil Velikov
On 23 February 2018 at 15:02, Eric Engestrom wrote: > On Friday, 2018-02-23 00:25:27 +, Emil Velikov wrote: >> On 19 February 2018 at 16:35, Eric Engestrom >> wrote: >> > From: Heiko Becker >> > >> > Helpful if your nm executable has a prefix based on the >> > architecture, for example. >>

Re: [PATCH libdrm v2] *-symbol-check: Don't hard-code nm executable

2018-02-23 Thread Eric Engestrom
On Friday, 2018-02-23 15:02:44 +, Eric Engestrom wrote: > On Friday, 2018-02-23 00:25:27 +, Emil Velikov wrote: > > On 19 February 2018 at 16:35, Eric Engestrom > > wrote: > > > From: Heiko Becker > > > > > > Helpful if your nm executable has a prefix based on the > > > architecture, for

Re: [PATCH libdrm v2] *-symbol-check: Don't hard-code nm executable

2018-02-23 Thread Eric Engestrom
On Friday, 2018-02-23 00:25:27 +, Emil Velikov wrote: > On 19 February 2018 at 16:35, Eric Engestrom > wrote: > > From: Heiko Becker > > > > Helpful if your nm executable has a prefix based on the > > architecture, for example. > > > > > +env_test = environment() > > +env_test.set('NM', fin

Re: [PATCH libdrm v2] *-symbol-check: Don't hard-code nm executable

2018-02-22 Thread Emil Velikov
On 19 February 2018 at 16:35, Eric Engestrom wrote: > From: Heiko Becker > > Helpful if your nm executable has a prefix based on the > architecture, for example. > > +env_test = environment() > +env_test.set('NM', find_program('nm').path()) > + Everything else is great, just not too sure about t

Re: [PATCH libdrm v2] *-symbol-check: Don't hard-code nm executable

2018-02-22 Thread Eric Anholt
Eric Engestrom writes: > From: Heiko Becker > > Helpful if your nm executable has a prefix based on the > architecture, for example. > > Signed-off-by: Heiko Becker > Cc: Timo Gurr > [Eric: v2: rebase and add Meson support] > Signed-off-by: Eric Engestrom Reviewed-by: Eric Anholt signatur

[PATCH libdrm v2] *-symbol-check: Don't hard-code nm executable

2018-02-19 Thread Eric Engestrom
From: Heiko Becker Helpful if your nm executable has a prefix based on the architecture, for example. Signed-off-by: Heiko Becker Cc: Timo Gurr [Eric: v2: rebase and add Meson support] Signed-off-by: Eric Engestrom --- amdgpu/amdgpu-symbol-check | 2 +- amdgpu/meson.build