Re: [PATCH linux-next] drm/amdgpu/vcn: Return void from the stop_dbg_mode

2022-08-24 Thread Alex Deucher
y > ; Wan Jiabing ; Greg Kroah-Hartman > ; Khalid Masum > Subject: [PATCH linux-next] drm/amdgpu/vcn: Return void from the stop_dbg_mode > > There is no point in returning an int here. It only returns 0 which the > caller never uses. Therefore return void and remove the unnecess

RE: [PATCH linux-next] drm/amdgpu/vcn: Return void from the stop_dbg_mode

2022-08-15 Thread Dong, Ruijing
: Deucher, Alexander ; Koenig, Christian ; Pan, Xinhui ; David Airlie ; Daniel Vetter ; Zhu, James ; Liu, Leo ; Jiang, Sonny ; Wan Jiabing ; Greg Kroah-Hartman ; Khalid Masum Subject: [PATCH linux-next] drm/amdgpu/vcn: Return void from the stop_dbg_mode There is no point in returning an int

[PATCH linux-next] drm/amdgpu/vcn: Return void from the stop_dbg_mode

2022-08-15 Thread Khalid Masum
There is no point in returning an int here. It only returns 0 which the caller never uses. Therefore return void and remove the unnecessary assignment. Addresses-Coverity: 1504988 ("Unused value") Fixes: 8da1170a16e4 ("drm/amdgpu: add VCN4 ip block support") Suggested-by: Ruijing Dong