Re:RE: [PATCH v2] drm/amd/amdgpu: cleanup coding style a bit

2020-05-11 Thread Bernard
dri-devel@lists.freedesktop.org" ,"linux-ker...@vger.kernel.org" 抄送人:"opensource.ker...@vivo.com" 主题:RE: [PATCH v2] drm/amd/amdgpu: cleanup coding style a bit>>-Original Message- >>From: dri-devel On Behalf Of >>Bernard Zhao >>Sent: Thursday, May 7

RE: [PATCH v2] drm/amd/amdgpu: cleanup coding style a bit

2020-05-08 Thread Ruhl, Michael J
amd-...@lists.freedesktop.org; dri- >de...@lists.freedesktop.org; linux-ker...@vger.kernel.org >Cc: opensource.ker...@vivo.com >Subject: [PATCH v2] drm/amd/amdgpu: cleanup coding style a bit > >There is DEVICE_ATTR mechanism in separate attribute define. >So this change is to use

[PATCH v2] drm/amd/amdgpu: cleanup coding style a bit

2020-05-08 Thread Bernard Zhao
There is DEVICE_ATTR mechanism in separate attribute define. So this change is to use attr array, also use sysfs_create_files in init function & sysfs_remove_files in fini function. This maybe make the code a bit readable. Signed-off-by: Bernard Zhao Changes since V1: *Use DEVICE_ATTR mechanism

Re: [PATCH v2] drm/amd/amdgpu: cleanup coding style a bit

2020-05-07 Thread Alex Deucher
On Thu, May 7, 2020 at 5:22 AM Christian König wrote: > > Am 07.05.20 um 11:13 schrieb Bernard Zhao: > > There is DEVICE_ATTR mechanism in separate attribute define. > > So this change is to use attr array, also use > > sysfs_create_files in init function & sysfs_remove_files in > > fini function.

Re: [PATCH v2] drm/amd/amdgpu: cleanup coding style a bit

2020-05-07 Thread Christian König
Am 07.05.20 um 11:13 schrieb Bernard Zhao: There is DEVICE_ATTR mechanism in separate attribute define. So this change is to use attr array, also use sysfs_create_files in init function & sysfs_remove_files in fini function. This maybe make the code a bit readable. Signed-off-by: Bernard Zhao