Re: [PATCH v2] drm/scheduler: set entity to NULL in drm_sched_entity_pop_job()

On 2023-04-19 06:07, Lucas Stach wrote: > Am Mittwoch, dem 19.04.2023 um 10:53 +0100 schrieb Steven Price: >> On 19/04/2023 10:44, Lucas Stach wrote: >>> Hi Steven, >>> >>> Am Mittwoch, dem 19.04.2023 um 10:39 +0100 schrieb Steven Price: On 18/04/2023 11:04, Danilo Krummrich wrote: > It

Re: [PATCH v2] drm/scheduler: set entity to NULL in drm_sched_entity_pop_job()

Am Mittwoch, dem 19.04.2023 um 10:53 +0100 schrieb Steven Price: > On 19/04/2023 10:44, Lucas Stach wrote: > > Hi Steven, > > > > Am Mittwoch, dem 19.04.2023 um 10:39 +0100 schrieb Steven Price: > > > On 18/04/2023 11:04, Danilo Krummrich wrote: > > > > It already happend a few times that patches

Re: [PATCH v2] drm/scheduler: set entity to NULL in drm_sched_entity_pop_job()

On 19/04/2023 10:53, Steven Price wrote: > On 19/04/2023 10:44, Lucas Stach wrote: >> Hi Steven, >> >> Am Mittwoch, dem 19.04.2023 um 10:39 +0100 schrieb Steven Price: >>> On 18/04/2023 11:04, Danilo Krummrich wrote: It already happend a few times that patches slipped through which

Re: [PATCH v2] drm/scheduler: set entity to NULL in drm_sched_entity_pop_job()

On 19/04/2023 10:44, Lucas Stach wrote: > Hi Steven, > > Am Mittwoch, dem 19.04.2023 um 10:39 +0100 schrieb Steven Price: >> On 18/04/2023 11:04, Danilo Krummrich wrote: >>> It already happend a few times that patches slipped through which >>> implemented access to an entity through a job that

Re: [PATCH v2] drm/scheduler: set entity to NULL in drm_sched_entity_pop_job()

Hi Steven, Am Mittwoch, dem 19.04.2023 um 10:39 +0100 schrieb Steven Price: > On 18/04/2023 11:04, Danilo Krummrich wrote: > > It already happend a few times that patches slipped through which > > implemented access to an entity through a job that was already removed > > from the entities queue.

Re: [PATCH v2] drm/scheduler: set entity to NULL in drm_sched_entity_pop_job()

On 18/04/2023 11:04, Danilo Krummrich wrote: > It already happend a few times that patches slipped through which > implemented access to an entity through a job that was already removed > from the entities queue. Since jobs and entities might have different > lifecycles, this can potentially cause

Re: [PATCH v2] drm/scheduler: set entity to NULL in drm_sched_entity_pop_job()

Reviewed-by: Luben Tuikov and applied to drm-misc-next. Thanks! Regards, Luben On 2023-04-18 06:04, Danilo Krummrich wrote: > It already happend a few times that patches slipped through which > implemented access to an entity through a job that was already removed > from the entities queue.

[PATCH v2] drm/scheduler: set entity to NULL in drm_sched_entity_pop_job()

It already happend a few times that patches slipped through which implemented access to an entity through a job that was already removed from the entities queue. Since jobs and entities might have different lifecycles, this can potentially cause UAF bugs. In order to make it obvious that a jobs