[PATCH v2 01/15] drm/dsi: Make mipi_dsi_dcs_{read,write}() symmetrical

2014-10-21 Thread Andrzej Hajda
On 10/21/2014 01:10 PM, Andrzej Hajda wrote: > On 10/14/2014 11:00 AM, Thierry Reding wrote: >> On Mon, Oct 13, 2014 at 02:29:15PM +0200, Andrzej Hajda wrote: >>> Hi Thierry, >>> >>> On 10/13/2014 12:16 PM, Thierry Reding wrote: From: Thierry Reding Currently the

[PATCH v2 01/15] drm/dsi: Make mipi_dsi_dcs_{read,write}() symmetrical

2014-10-21 Thread Andrzej Hajda
On 10/14/2014 11:00 AM, Thierry Reding wrote: > On Mon, Oct 13, 2014 at 02:29:15PM +0200, Andrzej Hajda wrote: >> Hi Thierry, >> >> On 10/13/2014 12:16 PM, Thierry Reding wrote: >>> From: Thierry Reding >>> >>> Currently the mipi_dsi_dcs_write() function requires the DCS command >>> byte to be

[PATCH v2 01/15] drm/dsi: Make mipi_dsi_dcs_{read, write}() symmetrical

2014-10-15 Thread Andrzej Hajda
On 10/15/2014 01:11 PM, Thierry Reding wrote: > On Wed, Oct 15, 2014 at 01:01:16PM +0200, Andrzej Hajda wrote: >> On 10/14/2014 04:16 PM, Thierry Reding wrote: >>> On Tue, Oct 14, 2014 at 03:53:26PM +0200, Andrzej Hajda wrote: On 10/14/2014 01:29 PM, Thierry Reding wrote: > On Tue, Oct

[PATCH v2 01/15] drm/dsi: Make mipi_dsi_dcs_{read, write}() symmetrical

2014-10-15 Thread Thierry Reding
On Wed, Oct 15, 2014 at 01:01:16PM +0200, Andrzej Hajda wrote: > On 10/14/2014 04:16 PM, Thierry Reding wrote: > > On Tue, Oct 14, 2014 at 03:53:26PM +0200, Andrzej Hajda wrote: > >> On 10/14/2014 01:29 PM, Thierry Reding wrote: > >>> On Tue, Oct 14, 2014 at 01:25:44PM +0200, Andrzej Hajda wrote:

[PATCH v2 01/15] drm/dsi: Make mipi_dsi_dcs_{read, write}() symmetrical

2014-10-15 Thread Andrzej Hajda
On 10/14/2014 04:16 PM, Thierry Reding wrote: > On Tue, Oct 14, 2014 at 03:53:26PM +0200, Andrzej Hajda wrote: >> On 10/14/2014 01:29 PM, Thierry Reding wrote: >>> On Tue, Oct 14, 2014 at 01:25:44PM +0200, Andrzej Hajda wrote: On 10/14/2014 12:57 PM, Thierry Reding wrote: > On Tue, Oct

[PATCH v2 01/15] drm/dsi: Make mipi_dsi_dcs_{read, write}() symmetrical

2014-10-14 Thread Thierry Reding
On Tue, Oct 14, 2014 at 03:53:26PM +0200, Andrzej Hajda wrote: > On 10/14/2014 01:29 PM, Thierry Reding wrote: > > On Tue, Oct 14, 2014 at 01:25:44PM +0200, Andrzej Hajda wrote: > >> On 10/14/2014 12:57 PM, Thierry Reding wrote: > >>> On Tue, Oct 14, 2014 at 12:38:15PM +0200, Andrzej Hajda wrote:

[PATCH v2 01/15] drm/dsi: Make mipi_dsi_dcs_{read, write}() symmetrical

2014-10-14 Thread Andrzej Hajda
On 10/14/2014 01:29 PM, Thierry Reding wrote: > On Tue, Oct 14, 2014 at 01:25:44PM +0200, Andrzej Hajda wrote: >> On 10/14/2014 12:57 PM, Thierry Reding wrote: >>> On Tue, Oct 14, 2014 at 12:38:15PM +0200, Andrzej Hajda wrote: On 10/14/2014 11:44 AM, Thierry Reding wrote: > On Tue, Oct

[PATCH v2 01/15] drm/dsi: Make mipi_dsi_dcs_{read, write}() symmetrical

2014-10-14 Thread Thierry Reding
On Tue, Oct 14, 2014 at 01:13:38PM +0200, Thierry Reding wrote: > On Tue, Oct 14, 2014 at 12:57:31PM +0200, Thierry Reding wrote: > > On Tue, Oct 14, 2014 at 12:38:15PM +0200, Andrzej Hajda wrote: > [...] > > > It has nothing to do with helpers symmetry, this is serious API change. > > > > No,

[PATCH v2 01/15] drm/dsi: Make mipi_dsi_dcs_{read, write}() symmetrical

2014-10-14 Thread Thierry Reding
On Tue, Oct 14, 2014 at 01:25:44PM +0200, Andrzej Hajda wrote: > On 10/14/2014 12:57 PM, Thierry Reding wrote: > > On Tue, Oct 14, 2014 at 12:38:15PM +0200, Andrzej Hajda wrote: > >> On 10/14/2014 11:44 AM, Thierry Reding wrote: > >>> On Tue, Oct 14, 2014 at 10:00:32AM +0200, Andrzej Hajda wrote:

[PATCH v2 01/15] drm/dsi: Make mipi_dsi_dcs_{read, write}() symmetrical

2014-10-14 Thread Andrzej Hajda
On 10/14/2014 12:57 PM, Thierry Reding wrote: > On Tue, Oct 14, 2014 at 12:38:15PM +0200, Andrzej Hajda wrote: >> On 10/14/2014 11:44 AM, Thierry Reding wrote: >>> On Tue, Oct 14, 2014 at 10:00:32AM +0200, Andrzej Hajda wrote: On 10/13/2014 12:16 PM, Thierry Reding wrote: > From: Thierry

[PATCH v2 01/15] drm/dsi: Make mipi_dsi_dcs_{read, write}() symmetrical

2014-10-14 Thread Thierry Reding
On Tue, Oct 14, 2014 at 12:57:31PM +0200, Thierry Reding wrote: > On Tue, Oct 14, 2014 at 12:38:15PM +0200, Andrzej Hajda wrote: [...] > > It has nothing to do with helpers symmetry, this is serious API change. > > No, it's not. It replaces an existing API, mipi_dsi_dcs_write() with a > different

[PATCH v2 01/15] drm/dsi: Make mipi_dsi_dcs_{read, write}() symmetrical

2014-10-14 Thread Andrzej Hajda
On 10/14/2014 11:44 AM, Thierry Reding wrote: > On Tue, Oct 14, 2014 at 10:00:32AM +0200, Andrzej Hajda wrote: >> On 10/13/2014 12:16 PM, Thierry Reding wrote: >>> From: Thierry Reding >>> >>> Currently the mipi_dsi_dcs_write() function requires the DCS command >>> byte to be embedded within the

[PATCH v2 01/15] drm/dsi: Make mipi_dsi_dcs_{read, write}() symmetrical

2014-10-14 Thread Thierry Reding
On Tue, Oct 14, 2014 at 12:38:15PM +0200, Andrzej Hajda wrote: > On 10/14/2014 11:44 AM, Thierry Reding wrote: > > On Tue, Oct 14, 2014 at 10:00:32AM +0200, Andrzej Hajda wrote: > >> On 10/13/2014 12:16 PM, Thierry Reding wrote: > >>> From: Thierry Reding > >>> > >>> Currently the

[PATCH v2 01/15] drm/dsi: Make mipi_dsi_dcs_{read, write}() symmetrical

2014-10-14 Thread Andrzej Hajda
On 10/14/2014 11:44 AM, Thierry Reding wrote: > On Tue, Oct 14, 2014 at 10:00:32AM +0200, Andrzej Hajda wrote: >> On 10/13/2014 12:16 PM, Thierry Reding wrote: >>> From: Thierry Reding >>> >>> Currently the mipi_dsi_dcs_write() function requires the DCS command >>> byte to be embedded within the

[PATCH v2 01/15] drm/dsi: Make mipi_dsi_dcs_{read, write}() symmetrical

2014-10-14 Thread Thierry Reding
On Tue, Oct 14, 2014 at 10:00:32AM +0200, Andrzej Hajda wrote: > On 10/13/2014 12:16 PM, Thierry Reding wrote: > > From: Thierry Reding > > > > Currently the mipi_dsi_dcs_write() function requires the DCS command > > byte to be embedded within the write buffer whereas mipi_dsi_dcs_read() > > has

[PATCH v2 01/15] drm/dsi: Make mipi_dsi_dcs_{read,write}() symmetrical

2014-10-14 Thread Thierry Reding
On Mon, Oct 13, 2014 at 02:29:15PM +0200, Andrzej Hajda wrote: > Hi Thierry, > > On 10/13/2014 12:16 PM, Thierry Reding wrote: > > From: Thierry Reding > > > > Currently the mipi_dsi_dcs_write() function requires the DCS command > > byte to be embedded within the write buffer whereas

[PATCH v2 01/15] drm/dsi: Make mipi_dsi_dcs_{read, write}() symmetrical

2014-10-14 Thread Andrzej Hajda
On 10/13/2014 12:16 PM, Thierry Reding wrote: > From: Thierry Reding > > Currently the mipi_dsi_dcs_write() function requires the DCS command > byte to be embedded within the write buffer whereas mipi_dsi_dcs_read() > has a separate parameter. Make them more symmetrical by adding an extra >

[PATCH v2 01/15] drm/dsi: Make mipi_dsi_dcs_{read,write}() symmetrical

2014-10-13 Thread Andrzej Hajda
Hi Thierry, On 10/13/2014 12:16 PM, Thierry Reding wrote: > From: Thierry Reding > > Currently the mipi_dsi_dcs_write() function requires the DCS command > byte to be embedded within the write buffer whereas mipi_dsi_dcs_read() > has a separate parameter. Make them more symmetrical by adding an

[PATCH v2 01/15] drm/dsi: Make mipi_dsi_dcs_{read, write}() symmetrical

2014-10-13 Thread Thierry Reding
From: Thierry Reding Currently the mipi_dsi_dcs_write() function requires the DCS command byte to be embedded within the write buffer whereas mipi_dsi_dcs_read() has a separate parameter. Make them more symmetrical by adding an extra command parameter to mipi_dsi_dcs_write().