Re: [PATCH v2 02/15] PCI: Add shorthand define for message signalled interrupt types

2020-06-04 Thread Logan Gunthorpe
On 2020-06-03 5:45 a.m., Piotr Stankiewicz wrote: > There are several places in the kernel which check/ask for MSI or MSI-X > interrupts. It would make sense to have a shorthand constant, similar to > PCI_IRQ_ALL_TYPES, to use in these situations. So add PCI_IRQ_MSI_TYPES, > for this purpose. >

Re: [PATCH v2 02/15] PCI: Add shorthand define for message signalled interrupt types

2020-06-03 Thread Luben Tuikov
That's a sensible change. In your title you can use "macro" or "definition" or "macro definition". "Define" is a verb. "PCI: Add a macro for message-signalled interrupt types" On 2020-06-03 7:45 a.m., Piotr Stankiewicz wrote: > There are several places in the kernel which check/ask for MSI or

[PATCH v2 02/15] PCI: Add shorthand define for message signalled interrupt types

2020-06-03 Thread Piotr Stankiewicz
There are several places in the kernel which check/ask for MSI or MSI-X interrupts. It would make sense to have a shorthand constant, similar to PCI_IRQ_ALL_TYPES, to use in these situations. So add PCI_IRQ_MSI_TYPES, for this purpose. Signed-off-by: Piotr Stankiewicz Suggested-by: Andy