Re: [PATCH v2 05/11] drm/tinydrm: Remove tinydrm_spi_max_transfer_size()

2019-10-16 Thread Andy Shevchenko
On Wed, Oct 16, 2019 at 07:44:51PM +0200, Daniel Vetter wrote: > On Wed, Oct 16, 2019 at 6:13 PM Andy Shevchenko > wrote: > > On Tue, Oct 15, 2019 at 05:57:20PM +0200, Daniel Vetter wrote: > > max_transfer_size should be a function. In that case it works. > > Why do you want to make it a functio

Re: [PATCH v2 05/11] drm/tinydrm: Remove tinydrm_spi_max_transfer_size()

2019-10-16 Thread Mark Brown
On Wed, Oct 16, 2019 at 07:44:51PM +0200, Daniel Vetter wrote: > On Wed, Oct 16, 2019 at 6:13 PM Andy Shevchenko > > On Tue, Oct 15, 2019 at 05:57:20PM +0200, Daniel Vetter wrote: > > > Something like this, as a test patch. > > max_transfer_size should be a function. In that case it works. > Why

Re: [PATCH v2 05/11] drm/tinydrm: Remove tinydrm_spi_max_transfer_size()

2019-10-16 Thread Daniel Vetter
On Wed, Oct 16, 2019 at 6:13 PM Andy Shevchenko wrote: > > On Tue, Oct 15, 2019 at 05:57:20PM +0200, Daniel Vetter wrote: > > On Tue, Oct 15, 2019 at 05:41:53PM +0200, Noralf Trønnes wrote: > > > Den 15.10.2019 16.32, skrev Andy Shevchenko: > > > > On Fri, Jul 19, 2019 at 05:59:10PM +0200, Noralf

Re: [PATCH v2 05/11] drm/tinydrm: Remove tinydrm_spi_max_transfer_size()

2019-10-16 Thread Andy Shevchenko
On Tue, Oct 15, 2019 at 05:57:20PM +0200, Daniel Vetter wrote: > On Tue, Oct 15, 2019 at 05:41:53PM +0200, Noralf Trønnes wrote: > > Den 15.10.2019 16.32, skrev Andy Shevchenko: > > > On Fri, Jul 19, 2019 at 05:59:10PM +0200, Noralf Trønnes wrote: > > >> spi-bcm2835 can handle >64kB buffers now so

Re: [PATCH v2 05/11] drm/tinydrm: Remove tinydrm_spi_max_transfer_size()

2019-10-16 Thread Andy Shevchenko
On Tue, Oct 15, 2019 at 06:05:16PM +0200, Daniel Vetter wrote: > On Tue, Oct 15, 2019 at 5:59 PM Andy Shevchenko > wrote: > > On Tue, Oct 15, 2019 at 05:41:53PM +0200, Noralf Trønnes wrote: > > > Den 15.10.2019 16.32, skrev Andy Shevchenko: > > > > On Fri, Jul 19, 2019 at 05:59:10PM +0200, Noralf

Re: [PATCH v2 05/11] drm/tinydrm: Remove tinydrm_spi_max_transfer_size()

2019-10-15 Thread Noralf Trønnes
Den 15.10.2019 17.59, skrev Andy Shevchenko: > On Tue, Oct 15, 2019 at 05:41:53PM +0200, Noralf Trønnes wrote: >> Den 15.10.2019 16.32, skrev Andy Shevchenko: >>> On Fri, Jul 19, 2019 at 05:59:10PM +0200, Noralf Trønnes wrote: spi-bcm2835 can handle >64kB buffers now so there is no need to c

Re: [PATCH v2 05/11] drm/tinydrm: Remove tinydrm_spi_max_transfer_size()

2019-10-15 Thread Daniel Vetter
On Tue, Oct 15, 2019 at 5:59 PM Andy Shevchenko wrote: > > On Tue, Oct 15, 2019 at 05:41:53PM +0200, Noralf Trønnes wrote: > > Den 15.10.2019 16.32, skrev Andy Shevchenko: > > > On Fri, Jul 19, 2019 at 05:59:10PM +0200, Noralf Trønnes wrote: > > >> spi-bcm2835 can handle >64kB buffers now so there

Re: [PATCH v2 05/11] drm/tinydrm: Remove tinydrm_spi_max_transfer_size()

2019-10-15 Thread Andy Shevchenko
On Tue, Oct 15, 2019 at 05:41:53PM +0200, Noralf Trønnes wrote: > Den 15.10.2019 16.32, skrev Andy Shevchenko: > > On Fri, Jul 19, 2019 at 05:59:10PM +0200, Noralf Trønnes wrote: > >> spi-bcm2835 can handle >64kB buffers now so there is no need to check > >> ->max_dma_len. The tinydrm_spi_max_trans

Re: [PATCH v2 05/11] drm/tinydrm: Remove tinydrm_spi_max_transfer_size()

2019-10-15 Thread Daniel Vetter
On Tue, Oct 15, 2019 at 05:41:53PM +0200, Noralf Trønnes wrote: > Den 15.10.2019 16.32, skrev Andy Shevchenko: > > On Fri, Jul 19, 2019 at 05:59:10PM +0200, Noralf Trønnes wrote: > >> spi-bcm2835 can handle >64kB buffers now so there is no need to check > >> ->max_dma_len. The tinydrm_spi_max_trans

Re: [PATCH v2 05/11] drm/tinydrm: Remove tinydrm_spi_max_transfer_size()

2019-10-15 Thread Noralf Trønnes
Den 15.10.2019 16.32, skrev Andy Shevchenko: > On Fri, Jul 19, 2019 at 05:59:10PM +0200, Noralf Trønnes wrote: >> spi-bcm2835 can handle >64kB buffers now so there is no need to check >> ->max_dma_len. The tinydrm_spi_max_transfer_size() max_len argument is >> not used by any callers, so not need

Re: [PATCH v2 05/11] drm/tinydrm: Remove tinydrm_spi_max_transfer_size()

2019-10-15 Thread Andy Shevchenko
On Tue, Oct 15, 2019 at 05:32:36PM +0300, Andy Shevchenko wrote: > On Fri, Jul 19, 2019 at 05:59:10PM +0200, Noralf Trønnes wrote: > > spi-bcm2835 can handle >64kB buffers now so there is no need to check > > ->max_dma_len. The tinydrm_spi_max_transfer_size() max_len argument is > > not used by any

Re: [PATCH v2 05/11] drm/tinydrm: Remove tinydrm_spi_max_transfer_size()

2019-10-15 Thread Andy Shevchenko
On Fri, Jul 19, 2019 at 05:59:10PM +0200, Noralf Trønnes wrote: > spi-bcm2835 can handle >64kB buffers now so there is no need to check > ->max_dma_len. The tinydrm_spi_max_transfer_size() max_len argument is > not used by any callers, so not needed. > > Then we have the spi_max module parameter.

[PATCH v2 05/11] drm/tinydrm: Remove tinydrm_spi_max_transfer_size()

2019-07-19 Thread Noralf Trønnes
spi-bcm2835 can handle >64kB buffers now so there is no need to check ->max_dma_len. The tinydrm_spi_max_transfer_size() max_len argument is not used by any callers, so not needed. Then we have the spi_max module parameter. It was added because staging/fbtft has support for it and there was a repo