Re: [PATCH v2 05/12] ASoC: hdmi-codec: Add a prepare hook

2021-06-03 Thread Maxime Ripard
Hi, On Tue, Jun 01, 2021 at 01:36:24PM +0100, Mark Brown wrote: > On Mon, May 31, 2021 at 01:12:17PM +0200, Takashi Iwai wrote: > > Maxime Ripard wrote: > > > > There's a build dependency between the DRM bits and the new hook > > > introduced in hdmi-codec, would you be ok with merging it

Re: [PATCH v2 05/12] ASoC: hdmi-codec: Add a prepare hook

2021-06-01 Thread Mark Brown
On Mon, May 31, 2021 at 01:12:17PM +0200, Takashi Iwai wrote: > Maxime Ripard wrote: > > There's a build dependency between the DRM bits and the new hook > > introduced in hdmi-codec, would you be ok with merging it through the > > drm tree? > Speaking of ALSA core changes, I'm fine with that.

Re: [PATCH v2 05/12] ASoC: hdmi-codec: Add a prepare hook

2021-05-31 Thread Takashi Iwai
On Mon, 31 May 2021 11:42:13 +0200, Maxime Ripard wrote: > > Hi Mark, Takashi, > > On Wed, May 26, 2021 at 11:39:21AM +0100, Mark Brown wrote: > > On Tue, May 25, 2021 at 03:23:47PM +0200, Maxime Ripard wrote: > > > The IEC958 status bit is usually set by the userspace after hw_params > > > has

Re: [PATCH v2 05/12] ASoC: hdmi-codec: Add a prepare hook

2021-05-31 Thread Maxime Ripard
Hi Mark, Takashi, On Wed, May 26, 2021 at 11:39:21AM +0100, Mark Brown wrote: > On Tue, May 25, 2021 at 03:23:47PM +0200, Maxime Ripard wrote: > > The IEC958 status bit is usually set by the userspace after hw_params > > has been called, so in order to use whatever is set by the userspace, we > >

Re: [PATCH v2 05/12] ASoC: hdmi-codec: Add a prepare hook

2021-05-26 Thread Mark Brown
On Tue, May 25, 2021 at 03:23:47PM +0200, Maxime Ripard wrote: > The IEC958 status bit is usually set by the userspace after hw_params > has been called, so in order to use whatever is set by the userspace, we > need to implement the prepare hook. Let's add it to the hdmi_codec_ops, > and mandate

[PATCH v2 05/12] ASoC: hdmi-codec: Add a prepare hook

2021-05-25 Thread Maxime Ripard
The IEC958 status bit is usually set by the userspace after hw_params has been called, so in order to use whatever is set by the userspace, we need to implement the prepare hook. Let's add it to the hdmi_codec_ops, and mandate that either prepare or hw_params is implemented. Signed-off-by: Maxime