Re: [PATCH v2 07/13] drm/msm/dpu: Add SM6350 support

2023-05-18 Thread Dmitry Baryshkov
On 21/04/2023 02:05, Konrad Dybcio wrote: On 21.04.2023 00:41, Dmitry Baryshkov wrote: On 21/04/2023 01:31, Konrad Dybcio wrote: Add SM6350 support to the DPU1 driver to enable display output. Signed-off-by: Konrad Dybcio Signed-off-by: Konrad Dybcio --- [...] + +static const struct dpu

Re: [PATCH v2 07/13] drm/msm/dpu: Add SM6350 support

2023-05-08 Thread Marijn Suijten
On 2023-05-05 15:11:44, Dmitry Baryshkov wrote: > On 27/04/2023 18:37, Marijn Suijten wrote: > > On 2023-04-21 00:31:16, Konrad Dybcio wrote: > >> Add SM6350 support to the DPU1 driver to enable display output. > >> > >> Signed-off-by: Konrad Dybcio > >> Signed-off-by: Konrad Dybcio > > > > Afte

Re: [PATCH v2 07/13] drm/msm/dpu: Add SM6350 support

2023-05-08 Thread Marijn Suijten
On 2023-04-28 16:03:54, Dmitry Baryshkov wrote: > >> + .qseed_type = DPU_SSPP_SCALER_QSEED4, > > > > I thought it was QSEED3LITE, but doesn't really matter as both are > > handled similarly. It'll anyway change when I resubmit: > > If I understood correctly, we mixed two things: hw stuff and t

Re: [PATCH v2 07/13] drm/msm/dpu: Add SM6350 support

2023-05-05 Thread Dmitry Baryshkov
On 27/04/2023 18:37, Marijn Suijten wrote: On 2023-04-21 00:31:16, Konrad Dybcio wrote: Add SM6350 support to the DPU1 driver to enable display output. Signed-off-by: Konrad Dybcio Signed-off-by: Konrad Dybcio After addressing the comments from Dmitry (CURSOR0->DMA1 and CURSOR1->DMA2), this

Re: [PATCH v2 07/13] drm/msm/dpu: Add SM6350 support

2023-04-28 Thread Dmitry Baryshkov
On 27/04/2023 18:37, Marijn Suijten wrote: On 2023-04-21 00:31:16, Konrad Dybcio wrote: Add SM6350 support to the DPU1 driver to enable display output. Signed-off-by: Konrad Dybcio Signed-off-by: Konrad Dybcio After addressing the comments from Dmitry (CURSOR0->DMA1 and CURSOR1->DMA2), this

Re: [PATCH v2 07/13] drm/msm/dpu: Add SM6350 support

2023-04-28 Thread Konrad Dybcio
On 4/27/23 16:48, Marijn Suijten wrote: > On 2023-04-27 17:37:42, Marijn Suijten wrote: >> On 2023-04-21 00:31:16, Konrad Dybcio wrote: >>> Add SM6350 support to the DPU1 driver to enable display output. >>> >>> Signed-off-by: Konrad Dybcio >>> Signed-off-by: Konrad Dybcio >> After addressing t

Re: [PATCH v2 07/13] drm/msm/dpu: Add SM6350 support

2023-04-28 Thread Konrad Dybcio
[...] >> + >> +static const struct dpu_caps sm6350_dpu_caps = { >> +.max_mixer_width = DEFAULT_DPU_OUTPUT_LINE_WIDTH, >> +.max_mixer_blendstages = 0x7, >> +.qseed_type = DPU_SSPP_SCALER_QSEED4, > I thought it was QSEED3LITE, but doesn't really matter as both are > handled similarly.

Re: [PATCH v2 07/13] drm/msm/dpu: Add SM6350 support

2023-04-27 Thread Marijn Suijten
On 2023-04-27 17:37:42, Marijn Suijten wrote: > On 2023-04-21 00:31:16, Konrad Dybcio wrote: > > Add SM6350 support to the DPU1 driver to enable display output. > > > > Signed-off-by: Konrad Dybcio > > Signed-off-by: Konrad Dybcio > > After addressing the comments from Dmitry (CURSOR0->DMA1 and

Re: [PATCH v2 07/13] drm/msm/dpu: Add SM6350 support

2023-04-27 Thread Marijn Suijten
On 2023-04-21 00:31:16, Konrad Dybcio wrote: > Add SM6350 support to the DPU1 driver to enable display output. > > Signed-off-by: Konrad Dybcio > Signed-off-by: Konrad Dybcio After addressing the comments from Dmitry (CURSOR0->DMA1 and CURSOR1->DMA2), this is: Reviewed-by: Marijn Suijten See

Re: [PATCH v2 07/13] drm/msm/dpu: Add SM6350 support

2023-04-20 Thread Dmitry Baryshkov
On 21/04/2023 02:05, Konrad Dybcio wrote: On 21.04.2023 00:41, Dmitry Baryshkov wrote: On 21/04/2023 01:31, Konrad Dybcio wrote: Add SM6350 support to the DPU1 driver to enable display output. Signed-off-by: Konrad Dybcio Signed-off-by: Konrad Dybcio --- [...] + +static const struct dpu

Re: [PATCH v2 07/13] drm/msm/dpu: Add SM6350 support

2023-04-20 Thread Konrad Dybcio
On 21.04.2023 00:41, Dmitry Baryshkov wrote: > On 21/04/2023 01:31, Konrad Dybcio wrote: >> Add SM6350 support to the DPU1 driver to enable display output. >> >> Signed-off-by: Konrad Dybcio >> Signed-off-by: Konrad Dybcio >> --- [...] >> + >> +static const struct dpu_sspp_cfg sm6350_sspp[] =

Re: [PATCH v2 07/13] drm/msm/dpu: Add SM6350 support

2023-04-20 Thread Dmitry Baryshkov
On 21/04/2023 01:31, Konrad Dybcio wrote: Add SM6350 support to the DPU1 driver to enable display output. Signed-off-by: Konrad Dybcio Signed-off-by: Konrad Dybcio --- .../gpu/drm/msm/disp/dpu1/catalog/dpu_6_4_sm6350.h | 191 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalo

[PATCH v2 07/13] drm/msm/dpu: Add SM6350 support

2023-04-20 Thread Konrad Dybcio
Add SM6350 support to the DPU1 driver to enable display output. Signed-off-by: Konrad Dybcio Signed-off-by: Konrad Dybcio --- .../gpu/drm/msm/disp/dpu1/catalog/dpu_6_4_sm6350.h | 191 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 1 + drivers/gpu/drm/msm/disp/dpu1