Re: [PATCH v2 09/12] fbdev: i740fb: use generic power management

2020-08-18 Thread Vaibhav Gupta
On Sun, Aug 16, 2020 at 10:24:42PM +0200, Sam Ravnborg wrote: > Hi Vaibhav > > On Tue, Aug 11, 2020 at 12:27:20AM +0530, Vaibhav Gupta wrote: > > Drivers should do only device-specific jobs. But in general, drivers using > > legacy PCI PM framework for .suspend()/.resume() have to manage many PCI

Re: [PATCH v2 09/12] fbdev: i740fb: use generic power management

2020-08-16 Thread Sam Ravnborg
Hi Vaibhav On Tue, Aug 11, 2020 at 12:27:20AM +0530, Vaibhav Gupta wrote: > Drivers should do only device-specific jobs. But in general, drivers using > legacy PCI PM framework for .suspend()/.resume() have to manage many PCI > PM-related tasks themselves which can be done by PCI Core itself.

[PATCH v2 09/12] fbdev: i740fb: use generic power management

2020-08-11 Thread Vaibhav Gupta
Drivers should do only device-specific jobs. But in general, drivers using legacy PCI PM framework for .suspend()/.resume() have to manage many PCI PM-related tasks themselves which can be done by PCI Core itself. This brings extra load on the driver and it directly calls PCI helper functions to