Re: [Intel-gfx] [PATCH v2 09/22] drm/dp_mst: Fix fractional bpp scaling in drm_dp_calc_pbn_mode()

2023-09-06 Thread Imre Deak
On Wed, Sep 06, 2023 at 01:45:51PM +0300, Ville Syrjälä wrote: > On Mon, Sep 04, 2023 at 01:22:27PM +0300, Imre Deak wrote: > > On Mon, Sep 04, 2023 at 05:53:11AM +0300, Ville Syrjälä wrote: > > > On Thu, Aug 24, 2023 at 11:05:04AM +0300, Imre Deak wrote: > > > > For fractional bpp values passed

Re: [Intel-gfx] [PATCH v2 09/22] drm/dp_mst: Fix fractional bpp scaling in drm_dp_calc_pbn_mode()

2023-09-06 Thread Ville Syrjälä
On Mon, Sep 04, 2023 at 01:22:27PM +0300, Imre Deak wrote: > On Mon, Sep 04, 2023 at 05:53:11AM +0300, Ville Syrjälä wrote: > > On Thu, Aug 24, 2023 at 11:05:04AM +0300, Imre Deak wrote: > > > For fractional bpp values passed to the function in a .4 fixed point > > > format, the fractional part is

Re: [Intel-gfx] [PATCH v2 09/22] drm/dp_mst: Fix fractional bpp scaling in drm_dp_calc_pbn_mode()

2023-09-04 Thread Imre Deak
On Mon, Sep 04, 2023 at 05:53:11AM +0300, Ville Syrjälä wrote: > On Thu, Aug 24, 2023 at 11:05:04AM +0300, Imre Deak wrote: > > For fractional bpp values passed to the function in a .4 fixed point > > format, the fractional part is currently ignored due to scaling bpp too > > early. Fix this by

Re: [Intel-gfx] [PATCH v2 09/22] drm/dp_mst: Fix fractional bpp scaling in drm_dp_calc_pbn_mode()

2023-09-03 Thread Ville Syrjälä
On Thu, Aug 24, 2023 at 11:05:04AM +0300, Imre Deak wrote: > For fractional bpp values passed to the function in a .4 fixed point > format, the fractional part is currently ignored due to scaling bpp too > early. Fix this by scaling the overhead factor instead and to avoid an > overflow

Re: [PATCH v2 09/22] drm/dp_mst: Fix fractional bpp scaling in drm_dp_calc_pbn_mode()

2023-08-30 Thread Lyude Paul
Amazing! This work looks awesome Imre, sorry it took me a little bit to get back to this :). For all of the DP MST helper patches: Reviewed-by: Lyude Paul On Thu, 2023-08-24 at 11:05 +0300, Imre Deak wrote: > For fractional bpp values passed to the function in a .4 fixed point > format, the

[PATCH v2 09/22] drm/dp_mst: Fix fractional bpp scaling in drm_dp_calc_pbn_mode()

2023-08-24 Thread Imre Deak
For fractional bpp values passed to the function in a .4 fixed point format, the fractional part is currently ignored due to scaling bpp too early. Fix this by scaling the overhead factor instead and to avoid an overflow multiplying bpp with the overhead factor instead of the clock rate. While at