Re: [PATCH v2 1/2] drm/file: Rehabilitate the firstopen hook for non-legacy drivers

2019-03-29 Thread Paul Kocialkowski
Hi, On Fri, 2019-03-29 at 18:42 +, Daniel Stone wrote: > Hi, > > On Fri, 29 Mar 2019 at 18:14, Eric Anholt wrote: > > Paul Kocialkowski writes: > > > I'm not totally convinced that it's okay to have a delay outside of > > > init/enumeration, even if it's a smaller delay. > > > > You'll

Re: [PATCH v2 1/2] drm/file: Rehabilitate the firstopen hook for non-legacy drivers

2019-03-29 Thread Daniel Stone
Hi, On Fri, 29 Mar 2019 at 18:14, Eric Anholt wrote: > Paul Kocialkowski writes: > > I'm not totally convinced that it's okay to have a delay outside of > > init/enumeration, even if it's a smaller delay. > > You'll have non-dumb buffers created during GL context creation, so > early in xserver

Re: [PATCH v2 1/2] drm/file: Rehabilitate the firstopen hook for non-legacy drivers

2019-03-29 Thread Eric Anholt
Paul Kocialkowski writes: > Hi, > > Le vendredi 29 mars 2019 à 16:25 +0100, Daniel Vetter a écrit : >> On Fri, Mar 29, 2019 at 04:02:23PM +0100, Paul Kocialkowski wrote: >> > Hi, >> > >> > On Fri, 2019-03-29 at 09:09 +, Daniel Stone wrote: >> > > Hi, >> > > >> > > On Thu, 28 Mar 2019 at

Re: [PATCH v2 1/2] drm/file: Rehabilitate the firstopen hook for non-legacy drivers

2019-03-29 Thread Paul Kocialkowski
Hi, Le vendredi 29 mars 2019 à 16:25 +0100, Daniel Vetter a écrit : > On Fri, Mar 29, 2019 at 04:02:23PM +0100, Paul Kocialkowski wrote: > > Hi, > > > > On Fri, 2019-03-29 at 09:09 +, Daniel Stone wrote: > > > Hi, > > > > > > On Thu, 28 Mar 2019 at 18:53, Daniel Vetter wrote: > > > > On

Re: [PATCH v2 1/2] drm/file: Rehabilitate the firstopen hook for non-legacy drivers

2019-03-29 Thread Daniel Vetter
On Fri, Mar 29, 2019 at 04:02:23PM +0100, Paul Kocialkowski wrote: > Hi, > > On Fri, 2019-03-29 at 09:09 +, Daniel Stone wrote: > > Hi, > > > > On Thu, 28 Mar 2019 at 18:53, Daniel Vetter wrote: > > > On Thu, Mar 21, 2019 at 04:27:06PM +0100, Paul Kocialkowski wrote: > > > > I don't see

Re: [PATCH v2 1/2] drm/file: Rehabilitate the firstopen hook for non-legacy drivers

2019-03-29 Thread Paul Kocialkowski
Hi, Le jeudi 28 mars 2019 à 19:53 +0100, Daniel Vetter a écrit : > On Thu, Mar 21, 2019 at 04:27:06PM +0100, Paul Kocialkowski wrote: > > Hi, > > > > Le mercredi 20 mars 2019 à 09:56 -0700, Eric Anholt a écrit : > > > Paul Kocialkowski writes: > > > > > > > The firstopen DRM driver hook was

Re: [PATCH v2 1/2] drm/file: Rehabilitate the firstopen hook for non-legacy drivers

2019-03-29 Thread Paul Kocialkowski
Hi, On Fri, 2019-03-29 at 09:09 +, Daniel Stone wrote: > Hi, > > On Thu, 28 Mar 2019 at 18:53, Daniel Vetter wrote: > > On Thu, Mar 21, 2019 at 04:27:06PM +0100, Paul Kocialkowski wrote: > > > I don't see other options either, and using firstclose/lastopen feels > > > overall more readable

Re: [PATCH v2 1/2] drm/file: Rehabilitate the firstopen hook for non-legacy drivers

2019-03-29 Thread Daniel Stone
Hi, On Thu, 28 Mar 2019 at 18:53, Daniel Vetter wrote: > On Thu, Mar 21, 2019 at 04:27:06PM +0100, Paul Kocialkowski wrote: > > I don't see other options either, and using firstclose/lastopen feels > > overall more readable in the driver code. > > > > I'm not sure there is such a big overhead

Re: [PATCH v2 1/2] drm/file: Rehabilitate the firstopen hook for non-legacy drivers

2019-03-28 Thread Daniel Vetter
On Thu, Mar 21, 2019 at 04:27:06PM +0100, Paul Kocialkowski wrote: > Hi, > > Le mercredi 20 mars 2019 à 09:56 -0700, Eric Anholt a écrit : > > Paul Kocialkowski writes: > > > > > The firstopen DRM driver hook was initially used to perform hardware > > > initialization, which is now considered

Re: [PATCH v2 1/2] drm/file: Rehabilitate the firstopen hook for non-legacy drivers

2019-03-21 Thread Eric Anholt
Paul Kocialkowski writes: > Hi, > > Le mercredi 20 mars 2019 à 09:56 -0700, Eric Anholt a écrit : >> Paul Kocialkowski writes: >> >> > The firstopen DRM driver hook was initially used to perform hardware >> > initialization, which is now considered legacy. Only a single user of >> > firstopen

Re: [PATCH v2 1/2] drm/file: Rehabilitate the firstopen hook for non-legacy drivers

2019-03-21 Thread Paul Kocialkowski
Hi, Le mercredi 20 mars 2019 à 09:56 -0700, Eric Anholt a écrit : > Paul Kocialkowski writes: > > > The firstopen DRM driver hook was initially used to perform hardware > > initialization, which is now considered legacy. Only a single user of > > firstopen remains at this point (savage). > > >

Re: [PATCH v2 1/2] drm/file: Rehabilitate the firstopen hook for non-legacy drivers

2019-03-20 Thread Eric Anholt
Paul Kocialkowski writes: > The firstopen DRM driver hook was initially used to perform hardware > initialization, which is now considered legacy. Only a single user of > firstopen remains at this point (savage). > > In some specific cases, non-legacy drivers may also need to implement > these

[PATCH v2 1/2] drm/file: Rehabilitate the firstopen hook for non-legacy drivers

2019-03-20 Thread Paul Kocialkowski
The firstopen DRM driver hook was initially used to perform hardware initialization, which is now considered legacy. Only a single user of firstopen remains at this point (savage). In some specific cases, non-legacy drivers may also need to implement these hooks. For instance on VC4, we need to