[PATCH v2 1/3] of: add common OF-based component functionality

2016-06-03 Thread Thierry Reding
On Fri, Jun 03, 2016 at 03:21:19PM +0100, Russell King wrote: [...] > diff --git a/drivers/of/of_component.c b/drivers/of/of_component.c [...] > +static void component_compare_of(struct device *dev, void *data) > +{ > + return dev->of_node == data; > +} The return statement here doesn't match

[PATCH v2 1/3] of: add common OF-based component functionality

2016-06-03 Thread Russell King - ARM Linux
On Fri, Jun 03, 2016 at 05:44:30PM +0200, Thierry Reding wrote: > On Fri, Jun 03, 2016 at 03:21:19PM +0100, Russell King wrote: > [...] > > diff --git a/drivers/of/of_component.c b/drivers/of/of_component.c > [...] > > +static void component_compare_of(struct device *dev, void *data) > > +{ > > +

[PATCH v2 1/3] of: add common OF-based component functionality

2016-06-03 Thread Russell King - ARM Linux
On Fri, Jun 03, 2016 at 10:29:40AM -0500, Rob Herring wrote: > On Fri, Jun 3, 2016 at 9:21 AM, Russell King > wrote: > > Add common OF-based component functionality for matching devices by > > device node, and releasing the device node at the appropraite time. > >

[PATCH v2 1/3] of: add common OF-based component functionality

2016-06-03 Thread Russell King
Add common OF-based component functionality for matching devices by device node, and releasing the device node at the appropraite time. Signed-off-by: Russell King --- drivers/of/Makefile | 2 +- drivers/of/of_component.c| 41

[PATCH v2 1/3] of: add common OF-based component functionality

2016-06-03 Thread Rob Herring
On Fri, Jun 3, 2016 at 10:36 AM, Russell King - ARM Linux wrote: > On Fri, Jun 03, 2016 at 10:29:40AM -0500, Rob Herring wrote: >> On Fri, Jun 3, 2016 at 9:21 AM, Russell King >> wrote: >> > Add common OF-based component functionality for matching devices by >> >

[PATCH v2 1/3] of: add common OF-based component functionality

2016-06-03 Thread Rob Herring
On Fri, Jun 3, 2016 at 9:21 AM, Russell King wrote: > Add common OF-based component functionality for matching devices by > device node, and releasing the device node at the appropraite time. > > Signed-off-by: Russell King > --- >