Re: [PATCH v2 1/4] drm/bridge: Add fwnode based helpers to get the next bridge

2024-03-09 Thread Dmitry Baryshkov
On Sat, 9 Mar 2024 at 14:03, Sui Jingfeng wrote: > > Hi, > > > On 2024/3/9 18:39, Dmitry Baryshkov wrote: > >> The code path of "creating a connector" plus the code path of "not > >> creating a connector" > >> forms a 'side-by-side' implementation imo. > >> > >> Besides, I have repeated many

Re: [PATCH v2 1/4] drm/bridge: Add fwnode based helpers to get the next bridge

2024-03-09 Thread Dmitry Baryshkov
On Sat, 9 Mar 2024 at 13:25, Sui Jingfeng wrote: > > Hi, > > > On 2024/3/9 18:39, Dmitry Baryshkov wrote: > > On Sat, 9 Mar 2024 at 11:33, Sui Jingfeng wrote: > >> Hi, > >> > >> > >> On 2024/3/8 04:40, Dmitry Baryshkov wrote: > > But really, there is nothing so hard about it: > > -

Re: [PATCH v2 1/4] drm/bridge: Add fwnode based helpers to get the next bridge

2024-03-09 Thread Sui Jingfeng
Hi, On 2024/3/9 18:39, Dmitry Baryshkov wrote: The code path of "creating a connector" plus the code path of "not creating a connector" forms a 'side-by-side' implementation imo. Besides, I have repeated many times: the DT already speak everything. Device drivers can completely know if there

Re: [PATCH v2 1/4] drm/bridge: Add fwnode based helpers to get the next bridge

2024-03-09 Thread Sui Jingfeng
Hi, On 2024/3/9 18:39, Dmitry Baryshkov wrote: On Sat, 9 Mar 2024 at 11:33, Sui Jingfeng wrote: Hi, On 2024/3/8 04:40, Dmitry Baryshkov wrote: But really, there is nothing so hard about it: - Change of_node to fw_node, apply an automatic patch changing this in bridge drivers. - Make

Re: [PATCH v2 1/4] drm/bridge: Add fwnode based helpers to get the next bridge

2024-03-09 Thread Dmitry Baryshkov
On Sat, 9 Mar 2024 at 11:33, Sui Jingfeng wrote: > > Hi, > > > On 2024/3/8 04:40, Dmitry Baryshkov wrote: > >>> But really, there is nothing so hard about it: > >>> - Change of_node to fw_node, apply an automatic patch changing this in > >>> bridge drivers. > >>> - Make drm_of_bridge functions

Re: [PATCH v2 1/4] drm/bridge: Add fwnode based helpers to get the next bridge

2024-03-09 Thread Sui Jingfeng
Hi, On 2024/3/8 04:40, Dmitry Baryshkov wrote: But really, there is nothing so hard about it: - Change of_node to fw_node, apply an automatic patch changing this in bridge drivers. - Make drm_of_bridge functions convert passed of_node and comp After this we can start cleaning up bridge

Re: [PATCH v2 1/4] drm/bridge: Add fwnode based helpers to get the next bridge

2024-03-07 Thread Sui Jingfeng
On 2024/3/8 05:09, Sui Jingfeng wrote: a most experienced A most experienced programmer & developer.

Re: [PATCH v2 1/4] drm/bridge: Add fwnode based helpers to get the next bridge

2024-03-07 Thread Sui Jingfeng
Hi, On 2024/3/8 04:40, Dmitry Baryshkov wrote: But really, there is nothing so hard about it: - Change of_node to fw_node, apply an automatic patch changing this in bridge drivers. - Make drm_of_bridge functions convert passed of_node and comp After this we can start cleaning up bridge

Re: [PATCH v2 1/4] drm/bridge: Add fwnode based helpers to get the next bridge

2024-03-07 Thread Dmitry Baryshkov
On Thu, 7 Mar 2024 at 22:32, Sui Jingfeng wrote: > > Hi, > > > On 2024/3/8 03:37, Dmitry Baryshkov wrote: > > On Thu, 7 Mar 2024 at 21:20, Sui Jingfeng wrote: > >> Hi, > >> > >> > >> On 2024/3/8 02:43, Dmitry Baryshkov wrote: > + > MODULE_AUTHOR("Ajay Kumar"); >

Re: [PATCH v2 1/4] drm/bridge: Add fwnode based helpers to get the next bridge

2024-03-07 Thread Sui Jingfeng
Hi, On 2024/3/8 03:37, Dmitry Baryshkov wrote: On Thu, 7 Mar 2024 at 21:20, Sui Jingfeng wrote: Hi, On 2024/3/8 02:43, Dmitry Baryshkov wrote: + MODULE_AUTHOR("Ajay Kumar"); MODULE_DESCRIPTION("DRM bridge infrastructure"); MODULE_LICENSE("GPL and additional rights"); diff --git

Re: [PATCH v2 1/4] drm/bridge: Add fwnode based helpers to get the next bridge

2024-03-07 Thread Dmitry Baryshkov
On Thu, 7 Mar 2024 at 21:20, Sui Jingfeng wrote: > > Hi, > > > On 2024/3/8 02:43, Dmitry Baryshkov wrote: > >> + > >> MODULE_AUTHOR("Ajay Kumar"); > >> MODULE_DESCRIPTION("DRM bridge infrastructure"); > >> MODULE_LICENSE("GPL and additional rights"); > >> diff --git

Re: [PATCH v2 1/4] drm/bridge: Add fwnode based helpers to get the next bridge

2024-03-07 Thread Sui Jingfeng
On 2024/3/8 03:20, Sui Jingfeng wrote: I think the drm_bridge should embeds 'struct device' 'struct device'  -> 'struct device *'

Re: [PATCH v2 1/4] drm/bridge: Add fwnode based helpers to get the next bridge

2024-03-07 Thread Sui Jingfeng
Hi, On 2024/3/8 02:43, Dmitry Baryshkov wrote: + MODULE_AUTHOR("Ajay Kumar"); MODULE_DESCRIPTION("DRM bridge infrastructure"); MODULE_LICENSE("GPL and additional rights"); diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h index 3606e1a7f965..d4c95afdd662 100644 ---

Re: [PATCH v2 1/4] drm/bridge: Add fwnode based helpers to get the next bridge

2024-03-07 Thread Dmitry Baryshkov
On Thu, 7 Mar 2024 at 19:23, Sui Jingfeng wrote: > > Currently, the various drm bridge drivers relay on OF infrastructures to > works very well. Yet there are platforms and/or don not has OF support. > Such as virtual display drivers, USB display apapters and ACPI based > systems etc. Add fwnode

[PATCH v2 1/4] drm/bridge: Add fwnode based helpers to get the next bridge

2024-03-07 Thread Sui Jingfeng
Currently, the various drm bridge drivers relay on OF infrastructures to works very well. Yet there are platforms and/or don not has OF support. Such as virtual display drivers, USB display apapters and ACPI based systems etc. Add fwnode based helpers to fill the niche, this may allows part of the