Re: [PATCH v2 11/17] drm/msm/dpu: Disable MDP vsync source selection on DPU 5.0.0 and above

2023-04-20 Thread Dmitry Baryshkov
On 21/04/2023 00:51, Marijn Suijten wrote: On 2023-04-20 04:03:31, Dmitry Baryshkov wrote: [..]   -static void dpu_hw_setup_vsync_source(struct dpu_hw_mdp *mdp, +static void dpu_hw_setup_vsync_source_v1(struct dpu_hw_mdp *mdp,   struct dpu_vsync_source_cfg *cfg) In my opinion _v1

Re: [PATCH v2 11/17] drm/msm/dpu: Disable MDP vsync source selection on DPU 5.0.0 and above

2023-04-20 Thread Marijn Suijten
On 2023-04-20 04:03:31, Dmitry Baryshkov wrote: [..] > >>>   -static void dpu_hw_setup_vsync_source(struct dpu_hw_mdp *mdp, > >>> +static void dpu_hw_setup_vsync_source_v1(struct dpu_hw_mdp *mdp, > >>>   struct dpu_vsync_source_cfg *cfg) > >> > >> In my opinion _v1 is not really

Re: [PATCH v2 11/17] drm/msm/dpu: Disable MDP vsync source selection on DPU 5.0.0 and above

2023-04-19 Thread Dmitry Baryshkov
On 20/04/2023 04:01, Konrad Dybcio wrote: On 20.04.2023 03:00, Dmitry Baryshkov wrote: On 17/04/2023 23:21, Marijn Suijten wrote: Since hardware revision 5.0.0 the TE configuration moved out of the PINGPONG block into the INTF block, including vsync source selection that was previously part

Re: [PATCH v2 11/17] drm/msm/dpu: Disable MDP vsync source selection on DPU 5.0.0 and above

2023-04-19 Thread Konrad Dybcio
On 20.04.2023 03:00, Dmitry Baryshkov wrote: > On 17/04/2023 23:21, Marijn Suijten wrote: >> Since hardware revision 5.0.0 the TE configuration moved out of the >> PINGPONG block into the INTF block, including vsync source selection >> that was previously part of MDP top.  Writing to the

Re: [PATCH v2 11/17] drm/msm/dpu: Disable MDP vsync source selection on DPU 5.0.0 and above

2023-04-19 Thread Dmitry Baryshkov
On 17/04/2023 23:21, Marijn Suijten wrote: Since hardware revision 5.0.0 the TE configuration moved out of the PINGPONG block into the INTF block, including vsync source selection that was previously part of MDP top. Writing to the MDP_VSYNC_SEL register has no effect anymore and is omitted

[PATCH v2 11/17] drm/msm/dpu: Disable MDP vsync source selection on DPU 5.0.0 and above

2023-04-17 Thread Marijn Suijten
Since hardware revision 5.0.0 the TE configuration moved out of the PINGPONG block into the INTF block, including vsync source selection that was previously part of MDP top. Writing to the MDP_VSYNC_SEL register has no effect anymore and is omitted downstream via the DPU/SDE_MDP_VSYNC_SEL feature