Re: [PATCH v2 2/3] drm/gma500: Fix WARN_ON(lock->magic != lock) error

2022-09-09 Thread Hans de Goede
Hi, On 9/9/22 10:20, Patrik Jakobsson wrote: > On Tue, Sep 6, 2022 at 10:38 PM Hans de Goede wrote: >> >> psb_gem_unpin() calls dma_resv_lock() but the underlying ww_mutex >> gets destroyed by drm_gem_object_release() move the >> drm_gem_object_release() call in psb_gem_free_object() to after >>

Re: [PATCH v2 2/3] drm/gma500: Fix WARN_ON(lock->magic != lock) error

2022-09-09 Thread Patrik Jakobsson
On Tue, Sep 6, 2022 at 10:38 PM Hans de Goede wrote: > > psb_gem_unpin() calls dma_resv_lock() but the underlying ww_mutex > gets destroyed by drm_gem_object_release() move the > drm_gem_object_release() call in psb_gem_free_object() to after > the unpin to fix the below warning: Looks good. I'll

[PATCH v2 2/3] drm/gma500: Fix WARN_ON(lock->magic != lock) error

2022-09-06 Thread Hans de Goede
psb_gem_unpin() calls dma_resv_lock() but the underlying ww_mutex gets destroyed by drm_gem_object_release() move the drm_gem_object_release() call in psb_gem_free_object() to after the unpin to fix the below warning: [ 79.693962] [ cut here ] [ 79.693992] DEBUG_LOCKS_W