Re: [PATCH v2 2/3] dt-bindings: backlight: add lm3630a bindings

2019-04-08 Thread Brian Masney
Hi Dan, On Tue, Apr 02, 2019 at 08:44:22AM -0500, Dan Murphy wrote: > Also one other comment I noticed when reviewing the code that there is no > definition to > which child led properties are optional and which are required? With the new YAML bindings, there is a separate toplevel 'required'

Re: [PATCH v2 2/3] dt-bindings: backlight: add lm3630a bindings

2019-04-03 Thread Dan Murphy
Hello On 4/1/19 5:30 AM, Brian Masney wrote: > Add new backlight bindings for the TI LM3630A dual-string white LED. > > Signed-off-by: Brian Masney > --- > .../leds/backlight/lm3630a-backlight.yaml | 112 ++ > 1 file changed, 112 insertions(+) > create mode 100644 >

Re: [PATCH v2 2/3] dt-bindings: backlight: add lm3630a bindings

2019-04-03 Thread Dan Murphy
Brian On 4/2/19 8:24 AM, Brian Masney wrote: > On Tue, Apr 02, 2019 at 07:56:55AM -0500, Dan Murphy wrote: >> This would connect control bank B to control bank A. Or just use a flag to >> denote to connect them >> and not use led-sources. But led-sources is the property of choice. >> >> led@0

Re: [PATCH v2 2/3] dt-bindings: backlight: add lm3630a bindings

2019-04-03 Thread Brian Masney
On Tue, Apr 02, 2019 at 07:56:55AM -0500, Dan Murphy wrote: > This would connect control bank B to control bank A. Or just use a flag to > denote to connect them > and not use led-sources. But led-sources is the property of choice. > > led@0 { > reg = <0>; > led-sources = < 0 1 >;

Re: [PATCH v2 2/3] dt-bindings: backlight: add lm3630a bindings

2019-04-02 Thread Rob Herring
On Tue, Apr 2, 2019 at 8:24 AM Brian Masney wrote: > > On Tue, Apr 02, 2019 at 07:56:55AM -0500, Dan Murphy wrote: > > This would connect control bank B to control bank A. Or just use a flag to > > denote to connect them > > and not use led-sources. But led-sources is the property of choice. >

Re: [PATCH v2 2/3] dt-bindings: backlight: add lm3630a bindings

2019-04-02 Thread Brian Masney
On Mon, Apr 01, 2019 at 11:39:26PM +0200, Pavel Machek wrote: > On Mon 2019-04-01 06:30:33, Brian Masney wrote: > > Add new backlight bindings for the TI LM3630A dual-string white LED. > > > > Signed-off-by: Brian Masney > > --- > > .../leds/backlight/lm3630a-backlight.yaml | 112 >

[PATCH v2 2/3] dt-bindings: backlight: add lm3630a bindings

2019-04-02 Thread Brian Masney
Add new backlight bindings for the TI LM3630A dual-string white LED. Signed-off-by: Brian Masney --- .../leds/backlight/lm3630a-backlight.yaml | 112 ++ 1 file changed, 112 insertions(+) create mode 100644

Re: [PATCH v2 2/3] dt-bindings: backlight: add lm3630a bindings

2019-04-01 Thread Pavel Machek
On Mon 2019-04-01 06:30:33, Brian Masney wrote: > Add new backlight bindings for the TI LM3630A dual-string white LED. > > Signed-off-by: Brian Masney > --- > .../leds/backlight/lm3630a-backlight.yaml | 112 ++ What is that? Is it future of all the bindings? Up to device