Re: [PATCH v2 2/7] drm/i915/gem: Typecheck page lookups

2022-07-12 Thread Gwan-gyeong Mun
On 7/6/22 8:10 PM, Mauro Carvalho Chehab wrote: On Wed, 6 Jul 2022 19:33:22 +0300 Gwan-gyeong Mun wrote: On 7/5/22 5:35 PM, Mauro Carvalho Chehab wrote: On Tue, 5 Jul 2022 15:24:50 +0300 Gwan-gyeong Mun wrote: From: Chris Wilson We need to check that we avoid integer overflows

Re: [PATCH v2 2/7] drm/i915/gem: Typecheck page lookups

2022-07-06 Thread Mauro Carvalho Chehab
On Wed, 6 Jul 2022 19:33:22 +0300 Gwan-gyeong Mun wrote: > On 7/5/22 5:35 PM, Mauro Carvalho Chehab wrote: > > On Tue, 5 Jul 2022 15:24:50 +0300 > > Gwan-gyeong Mun wrote: > > > >> From: Chris Wilson > >> > >> We need to check that we avoid integer overflows when looking up a page, > >>

Re: [PATCH v2 2/7] drm/i915/gem: Typecheck page lookups

2022-07-06 Thread Gwan-gyeong Mun
On 7/5/22 5:35 PM, Mauro Carvalho Chehab wrote: On Tue, 5 Jul 2022 15:24:50 +0300 Gwan-gyeong Mun wrote: From: Chris Wilson We need to check that we avoid integer overflows when looking up a page, and so fix all the instances where we have mistakenly used a plain integer instead of a

Re: [PATCH v2 2/7] drm/i915/gem: Typecheck page lookups

2022-07-05 Thread Mauro Carvalho Chehab
On Tue, 5 Jul 2022 15:24:50 +0300 Gwan-gyeong Mun wrote: > From: Chris Wilson > > We need to check that we avoid integer overflows when looking up a page, > and so fix all the instances where we have mistakenly used a plain > integer instead of a more suitable long. Be pedantic and add

[PATCH v2 2/7] drm/i915/gem: Typecheck page lookups

2022-07-05 Thread Gwan-gyeong Mun
From: Chris Wilson We need to check that we avoid integer overflows when looking up a page, and so fix all the instances where we have mistakenly used a plain integer instead of a more suitable long. Be pedantic and add integer typechecking to the lookup so that we can be sure that we are safe.