Re: [PATCH v2 2/7] drm/panel: himax-hx83102: Break out as separate driver

2024-04-24 Thread Doug Anderson
Hi, On Tue, Apr 23, 2024 at 7:42 PM cong yang wrote: > > Hi, > Thanks reply. > > Doug Anderson 于2024年4月24日周三 00:26写道: > > > > Hi, > > > > On Tue, Apr 23, 2024 at 2:37 AM cong yang > > wrote: > > > > > > > > +static int starry_init_cmd(struct hx83102 *ctx) > > > > > +{ > > > > > + struct

Re: [PATCH v2 2/7] drm/panel: himax-hx83102: Break out as separate driver

2024-04-23 Thread cong yang
Hi, Thanks reply. Doug Anderson 于2024年4月24日周三 00:26写道: > > Hi, > > On Tue, Apr 23, 2024 at 2:37 AM cong yang > wrote: > > > > > > +static int starry_init_cmd(struct hx83102 *ctx) > > > > +{ > > > > + struct mipi_dsi_device *dsi = ctx->dsi; > > > > + > > > > + mipi_dsi_dcs_write_seq(

Re: [PATCH v2 2/7] drm/panel: himax-hx83102: Break out as separate driver

2024-04-23 Thread Doug Anderson
Hi, On Tue, Apr 23, 2024 at 2:37 AM cong yang wrote: > > > > +static int starry_init_cmd(struct hx83102 *ctx) > > > +{ > > > + struct mipi_dsi_device *dsi = ctx->dsi; > > > + > > > + mipi_dsi_dcs_write_seq(dsi, HX83102_SETEXTC, 0x83, 0x10, 0x21, > > > 0x55, 0x00); > > > + > > > +

Re: [PATCH v2 2/7] drm/panel: himax-hx83102: Break out as separate driver

2024-04-23 Thread cong yang
Hi, Thanks for review. Doug Anderson 于2024年4月23日周二 05:24写道: > > Hi, > > On Mon, Apr 22, 2024 at 2:03 AM Cong Yang > wrote: > > > > The Starry HX83102 based mipi panel should never have been part of the boe > > tv101wum driver. Discussion with Doug and Linus in V1 [1], we need a > > separate driv

Re: [PATCH v2 2/7] drm/panel: himax-hx83102: Break out as separate driver

2024-04-22 Thread Doug Anderson
Hi, On Mon, Apr 22, 2024 at 2:03 AM Cong Yang wrote: > > The Starry HX83102 based mipi panel should never have been part of the boe > tv101wum driver. Discussion with Doug and Linus in V1 [1], we need a > separate driver to enable the hx83102 controller. > > In hx83102 driver, add DSI commands as

[PATCH v2 2/7] drm/panel: himax-hx83102: Break out as separate driver

2024-04-22 Thread Cong Yang
The Starry HX83102 based mipi panel should never have been part of the boe tv101wum driver. Discussion with Doug and Linus in V1 [1], we need a separate driver to enable the hx83102 controller. In hx83102 driver, add DSI commands as macros. So it can add some panels with same control model in the