Re: [Intel-gfx] [PATCH v2 2/9] drm: Add privacy-screen class (v2)

2021-06-03 Thread Emil Velikov
On Thu, 3 Jun 2021 at 12:59, Hans de Goede wrote: > > > >> +#include "drm_internal.h" > > > > I think we don't need this include, do we? > > The drm_privacy_screen device registered by a provider > uses /sys/class/drm as its class, quoting from > drm_privacy_screen.c drm_privacy_screen_register()

Re: [Intel-gfx] [PATCH v2 2/9] drm: Add privacy-screen class (v2)

2021-06-03 Thread Hans de Goede
Hi, On 6/1/21 5:31 PM, Emil Velikov wrote: > Hi Hans, > > What happened with this series, did it fall through the cracks? Sorta, as Marco already mentioned I think people are waiting for the user-space branches which he has on his personal git repos to be submitted as offical merge-req-s to GNOM

Re: [Intel-gfx] [PATCH v2 2/9] drm: Add privacy-screen class (v2)

2021-06-01 Thread Marco Trevisan
Hi Emil, On giu 1 2021, at 5:31 pm, Emil Velikov wrote: > Hi Hans, > > What happened with this series, did it fall through the cracks? It's mostly waiting me to finish to propose the changes to GNOME, unfortunately I've been busy in the past weeks with downstream work, so I couldn't finish it,

Re: [Intel-gfx] [PATCH v2 2/9] drm: Add privacy-screen class (v2)

2021-06-01 Thread Emil Velikov
Hi Hans, What happened with this series, did it fall through the cracks? On Wed, 21 Apr 2021 at 21:48, Hans de Goede wrote: > --- /dev/null > +++ b/drivers/gpu/drm/drm_privacy_screen.c > +#include "drm_internal.h" I think we don't need this include, do we? > --- /dev/null > +++ b/include/dr

[PATCH v2 2/9] drm: Add privacy-screen class (v2)

2021-04-21 Thread Hans de Goede
On some new laptops the LCD panel has a builtin electronic privacy-screen. We want to export this functionality as a property on the drm connector object. But often this functionality is not exposed on the GPU but on some other (ACPI) device. This commit adds a privacy-screen class allowing the dr