Re: [PATCH v2 3/3] phy: Add driver for mixel dphy found on imx8

2019-03-21 Thread Guido Günther
Hi, On Fri, Feb 08, 2019 at 11:55:41AM +, Robert Chiras wrote: [..snip..] > > > version of eLCDIF with Raydium RM67191 DSI panel on mScale850D > > > (i.MX8MQ). And I tried using this driver but there is no signal on > > > the > > > screen, even through the register values are all identical. Nex

Re: [PATCH v2 3/3] phy: Add driver for mixel dphy found on imx8

2019-03-06 Thread Guido Günther
Hi, On Fri, Feb 08, 2019 at 11:55:41AM +, Robert Chiras wrote: > Hi Guido > > On Vi, 2019-02-08 at 12:40 +0100, Guido Günther wrote: > > Hi Robert, > > On Wed, Feb 06, 2019 at 03:28:07PM +, Robert Chiras wrote: > > > > > > Hi Guido, > > > > > > Thanks for picking this up. It's interestin

Re: [PATCH v2 3/3] phy: Add driver for mixel dphy found on imx8

2019-02-09 Thread Robert Chiras
Hi Guido On Vi, 2019-02-08 at 12:40 +0100, Guido Günther wrote: > Hi Robert, > On Wed, Feb 06, 2019 at 03:28:07PM +, Robert Chiras wrote: > > > > Hi Guido, > > > > Thanks for picking this up. It's interesting to see that a lot has > > changed in the PHY API and the phy can be now configured

Re: [PATCH v2 3/3] phy: Add driver for mixel dphy found on imx8

2019-02-08 Thread Guido Günther
Hi Robert, On Wed, Feb 06, 2019 at 03:28:07PM +, Robert Chiras wrote: > Hi Guido, > > Thanks for picking this up. It's interesting to see that a lot has > changed in the PHY API and the phy can be now configured through the > API instead of exported function as I did in the NXP tree. > > I wa

Re: [PATCH v2 3/3] phy: Add driver for mixel dphy found on imx8

2019-02-08 Thread Guido Günther
Hi, On Fri, Feb 01, 2019 at 09:26:50AM -0200, Fabio Estevam wrote: > Hi Guido, > > Thanks for the respin. It looks better :-) Thanks for having a look! All your comments made sense to me and I've folded them into v3. Cheers, -- Guido > > On Fri, Feb 1, 2019 at 6:50 AM Guido Günther wrote: >

Re: [PATCH v2 3/3] phy: Add driver for mixel dphy found on imx8

2019-02-07 Thread Robert Chiras
Hi Guido, Thanks for picking this up. It's interesting to see that a lot has changed in the PHY API and the phy can be now configured through the API instead of exported function as I did in the NXP tree. I was going through your implementation and I noticed you also added the phy_ref clock to th

Re: [PATCH v2 3/3] phy: Add driver for mixel dphy found on imx8

2019-02-03 Thread kbuild test robot
Hi Guido, Thank you for the patch! Yet something to improve: [auto build test ERROR on phy/next] [also build test ERROR on next-20190201] [cannot apply to v5.0-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0da

Re: [PATCH v2 3/3] phy: Add driver for mixel dphy found on imx8

2019-02-01 Thread Fabio Estevam
Hi Guido, Thanks for the respin. It looks better :-) On Fri, Feb 1, 2019 at 6:50 AM Guido Günther wrote: > +config PHY_MIXEL_MIPI_DPHY > + tristate "Mixel MIPI DSI PHY support" > + depends on OF > + select GENERIC_PHY > + select GENERIC_PHY_MIPI_DPHY Since you converted

[PATCH v2 3/3] phy: Add driver for mixel dphy found on imx8

2019-02-01 Thread Guido Günther
This adds support for the Mixel DPHY as found on i.MX8 CPUs but since this is an IP core it will likely be found on others in the future. So instead of adding this to the nwl host driver make it a generic PHY driver. The driver supports the i.MX8MQ. Support for i.MX8QM and i.MX8QXP can be added on