Re: [PATCH v2 3/4] drm/omap: Make fixed resolution panels work

2013-03-19 Thread Tomi Valkeinen
On 2013-03-19 08:45, Archit Taneja wrote: > I was trying to come up with a macro which could add default ops to the > omap_dss_driver. It isn't straight forward as I thought, because you > need to choose either the default op, or the panel driver's op if it > exists. For example, I can't create a

[PATCH v2 3/4] drm/omap: Make fixed resolution panels work

2013-03-19 Thread Tomi Valkeinen
On 2013-03-19 08:45, Archit Taneja wrote: > I was trying to come up with a macro which could add default ops to the > omap_dss_driver. It isn't straight forward as I thought, because you > need to choose either the default op, or the panel driver's op if it > exists. For example, I can't create a

[PATCH v2 3/4] drm/omap: Make fixed resolution panels work

2013-03-19 Thread Archit Taneja
On Tuesday 12 March 2013 08:23 PM, Tomi Valkeinen wrote: > On 2013-03-12 16:38, Archit Taneja wrote: > >>> memcmp on two structs is often not a good idea. There could be padding >>> bytes there, with uninitialized data. I'm not sure if that's the case >>> here, though, but it could well change any

Re: [PATCH v2 3/4] drm/omap: Make fixed resolution panels work

2013-03-18 Thread Archit Taneja
On Tuesday 12 March 2013 08:23 PM, Tomi Valkeinen wrote: On 2013-03-12 16:38, Archit Taneja wrote: memcmp on two structs is often not a good idea. There could be padding bytes there, with uninitialized data. I'm not sure if that's the case here, though, but it could well change any time (perhap

[PATCH v2 3/4] drm/omap: Make fixed resolution panels work

2013-03-12 Thread Archit Taneja
On Tuesday 12 March 2013 07:36 PM, Tomi Valkeinen wrote: > On 2013-03-12 15:06, Archit Taneja wrote: >> The omapdrm driver requires omapdss panel drivers to expose ops like detect, >> set_timings and check_timings. These can be NULL for fixed panel DPI, DBI, >> DSI >> and SDI drivers. At some plac

[PATCH v2 3/4] drm/omap: Make fixed resolution panels work

2013-03-12 Thread Archit Taneja
The omapdrm driver requires omapdss panel drivers to expose ops like detect, set_timings and check_timings. These can be NULL for fixed panel DPI, DBI, DSI and SDI drivers. At some places, there are no checks to see if the panel driver has these ops or not, and that leads to a crash. The following

[PATCH v2 3/4] drm/omap: Make fixed resolution panels work

2013-03-12 Thread Tomi Valkeinen
On 2013-03-12 16:38, Archit Taneja wrote: >> memcmp on two structs is often not a good idea. There could be padding >> bytes there, with uninitialized data. I'm not sure if that's the case >> here, though, but it could well change any time (perhaps even depending >> on compiler version). > > I sa

[PATCH v2 3/4] drm/omap: Make fixed resolution panels work

2013-03-12 Thread Tomi Valkeinen
On 2013-03-12 15:06, Archit Taneja wrote: > The omapdrm driver requires omapdss panel drivers to expose ops like detect, > set_timings and check_timings. These can be NULL for fixed panel DPI, DBI, DSI > and SDI drivers. At some places, there are no checks to see if the panel > driver > has these

Re: [PATCH v2 3/4] drm/omap: Make fixed resolution panels work

2013-03-12 Thread Tomi Valkeinen
On 2013-03-12 16:38, Archit Taneja wrote: >> memcmp on two structs is often not a good idea. There could be padding >> bytes there, with uninitialized data. I'm not sure if that's the case >> here, though, but it could well change any time (perhaps even depending >> on compiler version). > > I sa

Re: [PATCH v2 3/4] drm/omap: Make fixed resolution panels work

2013-03-12 Thread Tomi Valkeinen
On 2013-03-12 15:06, Archit Taneja wrote: > The omapdrm driver requires omapdss panel drivers to expose ops like detect, > set_timings and check_timings. These can be NULL for fixed panel DPI, DBI, DSI > and SDI drivers. At some places, there are no checks to see if the panel > driver > has these

Re: [PATCH v2 3/4] drm/omap: Make fixed resolution panels work

2013-03-12 Thread Archit Taneja
On Tuesday 12 March 2013 07:36 PM, Tomi Valkeinen wrote: On 2013-03-12 15:06, Archit Taneja wrote: The omapdrm driver requires omapdss panel drivers to expose ops like detect, set_timings and check_timings. These can be NULL for fixed panel DPI, DBI, DSI and SDI drivers. At some places, there ar

[PATCH v2 3/4] drm/omap: Make fixed resolution panels work

2013-03-12 Thread Archit Taneja
The omapdrm driver requires omapdss panel drivers to expose ops like detect, set_timings and check_timings. These can be NULL for fixed panel DPI, DBI, DSI and SDI drivers. At some places, there are no checks to see if the panel driver has these ops or not, and that leads to a crash. The following