Re: [PATCH v2 3/7] drm: rcar-du: lvsd: Add reset control

2023-01-23 Thread Tomi Valkeinen
On 20/01/2023 19:05, Laurent Pinchart wrote: On Fri, Jan 20, 2023 at 06:18:07PM +0200, Laurent Pinchart wrote: Hi Tomi, Thank you for the patch. Another small comment: in the commit message, s/lvsd/lvds/ Yep. On Fri, Jan 20, 2023 at 10:50:05AM +0200, Tomi Valkeinen wrote: Reset LVDS usin

[PATCH v2 3/7] drm: rcar-du: lvsd: Add reset control

2023-01-20 Thread Tomi Valkeinen
Reset LVDS using the reset control as CPG reset/release is required in the hardware manual sequence. Based on a BSP patch from Koji Matsuoka . Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/rcar-du/Kconfig | 1 + drivers/gpu/drm/rcar-du/rcar_lvds.c | 19 ++- 2 files chan

Re: [PATCH v2 3/7] drm: rcar-du: lvsd: Add reset control

2023-01-20 Thread Laurent Pinchart
On Fri, Jan 20, 2023 at 06:18:07PM +0200, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. Another small comment: in the commit message, s/lvsd/lvds/ > On Fri, Jan 20, 2023 at 10:50:05AM +0200, Tomi Valkeinen wrote: > > Reset LVDS using the reset control as CPG reset/release is re

Re: [PATCH v2 3/7] drm: rcar-du: lvsd: Add reset control

2023-01-20 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Fri, Jan 20, 2023 at 10:50:05AM +0200, Tomi Valkeinen wrote: > Reset LVDS using the reset control as CPG reset/release is required in > the hardware manual sequence. > > Based on a BSP patch from Koji Matsuoka . > > Signed-off-by: Tomi Valkeinen > --- > dr