Re: [PATCH v2 5/5] fbdev: Define framebuffer I/O from Linux' I/O functions

2023-04-29 Thread Arnd Bergmann
On Sat, Apr 29, 2023, at 14:26, Thomas Zimmermann wrote: > Am 28.04.23 um 15:17 schrieb Arnd Bergmann: >> The only implementations in fbdev are >> >> 1) sparc sbus >> 2) __raw_writel >> 3) direct pointer dereference >> >> But none use the byte-swapping writel() implementations, and >> the o

Re: [PATCH v2 5/5] fbdev: Define framebuffer I/O from Linux' I/O functions

2023-04-29 Thread Thomas Zimmermann
Hi Sam Am 28.04.23 um 18:54 schrieb Sam Ravnborg: Hi Thomas, On Fri, Apr 28, 2023 at 04:18:38PM +0200, Thomas Zimmermann wrote: I'd be happy to have fb_() wrappers that are I/O helpers without ordering guarantees. I'd just wouldn't want them in How about throwing them into a new drm_fb.h he

Re: [PATCH v2 5/5] fbdev: Define framebuffer I/O from Linux' I/O functions

2023-04-29 Thread Thomas Zimmermann
Hi Am 28.04.23 um 15:17 schrieb Arnd Bergmann: On Fri, Apr 28, 2023, at 13:27, Geert Uytterhoeven wrote: On Fri, Apr 28, 2023 at 2:18 PM Robin Murphy wrote: On 2023-04-28 10:27, Thomas Zimmermann wrote: - -#elif defined(__i386__) || defined(__alpha__) || defined(__x86_64__) || \ -

Re: [PATCH v2 5/5] fbdev: Define framebuffer I/O from Linux' I/O functions

2023-04-28 Thread Sam Ravnborg
Hi Thomas, On Fri, Apr 28, 2023 at 04:18:38PM +0200, Thomas Zimmermann wrote: > I'd be happy to have fb_() wrappers that are I/O helpers without > ordering guarantees. I'd just wouldn't want them in How about throwing them into a new drm_fb.h header file. This header file could be the home for a

Re: [PATCH v2 5/5] fbdev: Define framebuffer I/O from Linux' I/O functions

2023-04-28 Thread Thomas Zimmermann
Hi Am 28.04.23 um 15:12 schrieb Sam Ravnborg: Hi Thomas, On Fri, Apr 28, 2023 at 11:27:11AM +0200, Thomas Zimmermann wrote: Implement framebuffer I/O helpers, such as fb_read*() and fb_write*() with Linux' regular I/O functions. Remove all ifdef cases for the various architectures. Most of th

Re: [PATCH v2 5/5] fbdev: Define framebuffer I/O from Linux' I/O functions

2023-04-28 Thread Arnd Bergmann
On Fri, Apr 28, 2023, at 13:27, Geert Uytterhoeven wrote: > On Fri, Apr 28, 2023 at 2:18 PM Robin Murphy wrote: >> On 2023-04-28 10:27, Thomas Zimmermann wrote: >> > - >> > -#elif defined(__i386__) || defined(__alpha__) || defined(__x86_64__) || >> >\ >> > - defined(__hppa__) || define

Re: [PATCH v2 5/5] fbdev: Define framebuffer I/O from Linux' I/O functions

2023-04-28 Thread Sam Ravnborg
Hi Thomas, On Fri, Apr 28, 2023 at 11:27:11AM +0200, Thomas Zimmermann wrote: > Implement framebuffer I/O helpers, such as fb_read*() and fb_write*() > with Linux' regular I/O functions. Remove all ifdef cases for the > various architectures. > > Most of the supported architectures use __raw_() I

Re: [PATCH v2 5/5] fbdev: Define framebuffer I/O from Linux' I/O functions

2023-04-28 Thread Thomas Zimmermann
Hi Am 28.04.23 um 14:27 schrieb Geert Uytterhoeven: [...] In addition, the non-raw variants may do some extras to guarantee ordering, which you do not need on a frame buffer. Given this comment, should we declare the fb_() helpers in or ? I still don't like the idea of having the function

Re: [PATCH v2 5/5] fbdev: Define framebuffer I/O from Linux' I/O functions

2023-04-28 Thread Thomas Zimmermann
Hi Robin, Geert Am 28.04.23 um 14:27 schrieb Geert Uytterhoeven: On Fri, Apr 28, 2023 at 2:18 PM Robin Murphy wrote: On 2023-04-28 10:27, Thomas Zimmermann wrote: Implement framebuffer I/O helpers, such as fb_read*() and fb_write*() with Linux' regular I/O functions. Remove all ifdef cases fo

Re: [PATCH v2 5/5] fbdev: Define framebuffer I/O from Linux' I/O functions

2023-04-28 Thread Geert Uytterhoeven
On Fri, Apr 28, 2023 at 2:18 PM Robin Murphy wrote: > On 2023-04-28 10:27, Thomas Zimmermann wrote: > > Implement framebuffer I/O helpers, such as fb_read*() and fb_write*() > > with Linux' regular I/O functions. Remove all ifdef cases for the > > various architectures. > > > > Most of the support

Re: [PATCH v2 5/5] fbdev: Define framebuffer I/O from Linux' I/O functions

2023-04-28 Thread Robin Murphy
On 2023-04-28 10:27, Thomas Zimmermann wrote: Implement framebuffer I/O helpers, such as fb_read*() and fb_write*() with Linux' regular I/O functions. Remove all ifdef cases for the various architectures. Most of the supported architectures use __raw_() I/O functions or treat framebuffer memory

[PATCH v2 5/5] fbdev: Define framebuffer I/O from Linux' I/O functions

2023-04-28 Thread Thomas Zimmermann
Implement framebuffer I/O helpers, such as fb_read*() and fb_write*() with Linux' regular I/O functions. Remove all ifdef cases for the various architectures. Most of the supported architectures use __raw_() I/O functions or treat framebuffer memory like regular memory. This is also implemented by