Re: [PATCH v2 5/9] drm/nouveau: Use drm_connector_for_each_possible_encoder()

2018-07-02 Thread Ville Syrjälä
On Mon, Jul 02, 2018 at 04:04:45PM +0300, Ville Syrjälä wrote: > On Sat, Jun 30, 2018 at 10:12:21PM +0300, Dan Carpenter wrote: > > Hi Ville, > > > > Thank you for the patch! Perhaps something to improve: > > > > url: > >

Re: [PATCH v2 5/9] drm/nouveau: Use drm_connector_for_each_possible_encoder()

2018-07-02 Thread Ville Syrjälä
On Sat, Jun 30, 2018 at 10:12:21PM +0300, Dan Carpenter wrote: > Hi Ville, > > Thank you for the patch! Perhaps something to improve: > > url: > https://github.com/0day-ci/linux/commits/Ville-Syrjala/drm-Third-attempt-at-fixing-the-fb-helper-best_encoder-mess/20180629-014202 > base:

Re: [PATCH v2 5/9] drm/nouveau: Use drm_connector_for_each_possible_encoder()

2018-06-30 Thread Dan Carpenter
Hi Ville, Thank you for the patch! Perhaps something to improve: url: https://github.com/0day-ci/linux/commits/Ville-Syrjala/drm-Third-attempt-at-fixing-the-fb-helper-best_encoder-mess/20180629-014202 base: git://people.freedesktop.org/~airlied/linux.git drm-next smatch warnings:

[PATCH v2 5/9] drm/nouveau: Use drm_connector_for_each_possible_encoder()

2018-06-28 Thread Ville Syrjala
From: Ville Syrjälä Use drm_connector_for_each_possible_encoder() for iterating connector->encoder_ids[]. A bit more convenient not having to deal with the implementation details. v2: Replace drm_for_each_connector_encoder_ids() with drm_connector_for_each_possible_encoder() (Daniel) Cc: