RE: [PATCH v2 RESEND 2/2] drm/i915/icl: Implement half float formats

2019-02-04 Thread Strasser, Kevin
Ville Syrjälä wrote: > Kevin Strasser wrote: > > Ville Syrjälä wrote: > > > is_hdr_plane() is around now, please use it. > > > > I don't think I can use icl_is_hdr_plane here without some refactoring. It > > requires the plane->base to be initialized through drm_universal_plane_init, > > which depe

Re: [PATCH v2 RESEND 2/2] drm/i915/icl: Implement half float formats

2019-02-04 Thread Ville Syrjälä
On Fri, Feb 01, 2019 at 09:38:57PM +, Strasser, Kevin wrote: > Ville Syrjälä wrote: > > > @@ -1774,6 +1776,45 @@ static const u32 skl_planar_formats[] = { > > >DRM_FORMAT_NV12, > > > }; > > > > > > +static const uint32_t icl_hdr_plane_formats[] = { > > > > Please switch to u32 & co. We

RE: [PATCH v2 RESEND 2/2] drm/i915/icl: Implement half float formats

2019-02-01 Thread Strasser, Kevin
Ville Syrjälä wrote: > > @@ -1774,6 +1776,45 @@ static const u32 skl_planar_formats[] = { > >DRM_FORMAT_NV12, > > }; > > > > +static const uint32_t icl_hdr_plane_formats[] = { > > Please switch to u32 & co. We recently had a mass conversion in the > driver. Will do. Looks like the CI caug

Re: [PATCH v2 RESEND 2/2] drm/i915/icl: Implement half float formats

2019-02-01 Thread Ville Syrjälä
On Fri, Feb 01, 2019 at 09:43:40AM -0800, Kevin Strasser wrote: > 64 bpp half float formats are supported on hdr planes only and are subject > to the following restrictions: > * 90/270 rotation not supported > * Yf Tiling not supported > * Frame Buffer Compression not supported > * Color Ke

[PATCH v2 RESEND 2/2] drm/i915/icl: Implement half float formats

2019-02-01 Thread Kevin Strasser
64 bpp half float formats are supported on hdr planes only and are subject to the following restrictions: * 90/270 rotation not supported * Yf Tiling not supported * Frame Buffer Compression not supported * Color Keying not supported v2: - Drop handling pixel normalize register - Don't use