Re: [PATCH v21 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2019-12-19 Thread Enric Balletbo i Serra
Hi Ezequiel, Many thanks for the review, I am just preparing the next version to send. On 16/12/19 18:07, Ezequiel Garcia wrote: > On Mon, 2019-12-16 at 14:58 +0100, Enric Balletbo i Serra wrote: >> From: Jitao Shi >> >> This patch adds drm_bridge driver for parade DSI to eDP bridge chip. >> >>

Re: [PATCH v21 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2019-12-18 Thread Ezequiel Garcia
On Wed, 2019-12-18 at 16:21 +0100, Enric Balletbo i Serra wrote: > Hi Ezequiel, > > Many thanks for the review, I am just preparing the next version to send. > [..] > > > + > > > +#define PAGE1_VSTART 0x6b > > > +#define PAGE2_SPI_CFG3 0x82 > > > +#define I2C_TO_SPI_RESET

Re: [PATCH v21 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2019-12-18 Thread Enric Balletbo i Serra
Hi Laurent, Many thanks for the quick response and the review. Just preparing a new version to send. On 16/12/19 17:32, Laurent Pinchart wrote: > Hello Enric and Jitao, > > Thank you for the patch. > > On Mon, Dec 16, 2019 at 02:58:34PM +0100, Enric Balletbo i Serra wrote: >> From: Jitao Shi

[PATCH v21 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2019-12-17 Thread Enric Balletbo i Serra
From: Jitao Shi This patch adds drm_bridge driver for parade DSI to eDP bridge chip. Signed-off-by: Jitao Shi Reviewed-by: Daniel Kurtz Reviewed-by: Enric Balletbo i Serra [uli: followed API changes, removed FW update feature] Signed-off-by: Ulrich Hecht Signed-off-by: Enric Balletbo i

Re: [PATCH v21 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2019-12-16 Thread Ezequiel Garcia
On Mon, 2019-12-16 at 14:58 +0100, Enric Balletbo i Serra wrote: > From: Jitao Shi > > This patch adds drm_bridge driver for parade DSI to eDP bridge chip. > > Signed-off-by: Jitao Shi > Reviewed-by: Daniel Kurtz > Reviewed-by: Enric Balletbo i Serra > [uli: followed API changes, removed FW

Re: [PATCH v21 2/2] drm/bridge: Add I2C based driver for ps8640 bridge

2019-12-16 Thread Laurent Pinchart
Hello Enric and Jitao, Thank you for the patch. On Mon, Dec 16, 2019 at 02:58:34PM +0100, Enric Balletbo i Serra wrote: > From: Jitao Shi > > This patch adds drm_bridge driver for parade DSI to eDP bridge chip. > > Signed-off-by: Jitao Shi > Reviewed-by: Daniel Kurtz > Reviewed-by: Enric