Re: [PATCH v3] drm/msm/dp: check hpd_state before push idle pattern at dp_bridge_disable()

2022-08-18 Thread Abhinav Kumar
Hi Stephen On 8/15/2022 10:08 AM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-08-11 08:20:01) On 8/10/2022 6:00 PM, Abhinav Kumar wrote: Even then, you do have a valid point. DRM framework should not have caused the disable path to happen without an enable. I went through the stack

Re: [PATCH v3] drm/msm/dp: check hpd_state before push idle pattern at dp_bridge_disable()

2022-08-16 Thread Kuogee Hsieh
On 8/15/2022 10:08 AM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-08-11 08:20:01) On 8/10/2022 6:00 PM, Abhinav Kumar wrote: Even then, you do have a valid point. DRM framework should not have caused the disable path to happen without an enable. I went through the stack mentioned in the

Re: [PATCH v3] drm/msm/dp: check hpd_state before push idle pattern at dp_bridge_disable()

2022-08-15 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-08-11 08:20:01) > > On 8/10/2022 6:00 PM, Abhinav Kumar wrote: > > > > Even then, you do have a valid point. DRM framework should not have > > caused the disable path to happen without an enable. > > > > I went through the stack mentioned in the issue. > > > > Lets see

Re: [PATCH v3] drm/msm/dp: check hpd_state before push idle pattern at dp_bridge_disable()

2022-08-11 Thread Kuogee Hsieh
On 8/10/2022 6:00 PM, Abhinav Kumar wrote: Hi Stephen On 8/10/2022 5:09 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-08-10 16:57:51) On 8/10/2022 3:22 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-08-10 12:25:51) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c

Re: [PATCH v3] drm/msm/dp: check hpd_state before push idle pattern at dp_bridge_disable()

2022-08-10 Thread Abhinav Kumar
Hi Stephen On 8/10/2022 5:09 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-08-10 16:57:51) On 8/10/2022 3:22 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-08-10 12:25:51) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index b36f8b6..678289a

Re: [PATCH v3] drm/msm/dp: check hpd_state before push idle pattern at dp_bridge_disable()

2022-08-10 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-08-10 16:57:51) > > On 8/10/2022 3:22 PM, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2022-08-10 12:25:51) > >> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > >> b/drivers/gpu/drm/msm/dp/dp_display.c > >> index b36f8b6..678289a 100644 > >> ---

Re: [PATCH v3] drm/msm/dp: check hpd_state before push idle pattern at dp_bridge_disable()

2022-08-10 Thread Kuogee Hsieh
On 8/10/2022 3:22 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-08-10 12:25:51) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index b36f8b6..678289a 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@

Re: [PATCH v3] drm/msm/dp: check hpd_state before push idle pattern at dp_bridge_disable()

2022-08-10 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-08-10 12:25:51) > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index b36f8b6..678289a 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -1729,10 +1729,20 @@ void

[PATCH v3] drm/msm/dp: check hpd_state before push idle pattern at dp_bridge_disable()

2022-08-10 Thread Kuogee Hsieh
dp_bridge_disable() is the first step toward tearing down main link. Its major function is to start transmitting idle pattern to replace video stream. This patch will check hpd_state to make sure main link is enabled before commit changes of main link's configuration to push idle pattern out to