Re: [PATCH v3] drm/plane: Add documentation about software color conversion.

2023-09-13 Thread Michel Dänzer
On 9/13/23 10:14, Jocelyn Falempe wrote: > On 12/09/2023 17:57, Michel Dänzer wrote: >> On 9/11/23 10:38, Pekka Paalanen wrote: >>> On Fri, 8 Sep 2023 17:10:46 +0200 >>> Thomas Zimmermann wrote: Am 08.09.23 um 16:41 schrieb Pekka Paalanen: > On Fri, 8 Sep 2023 15:56:51 +0200 > Thomas

Re: [PATCH v3] drm/plane: Add documentation about software color conversion.

2023-09-13 Thread Jocelyn Falempe
On 12/09/2023 17:57, Michel Dänzer wrote: On 9/11/23 10:38, Pekka Paalanen wrote: On Fri, 8 Sep 2023 17:10:46 +0200 Thomas Zimmermann wrote: Am 08.09.23 um 16:41 schrieb Pekka Paalanen: On Fri, 8 Sep 2023 15:56:51 +0200 Thomas Zimmermann wrote: I have a number of concerns. My point it not

Re: [PATCH v3] drm/plane: Add documentation about software color conversion.

2023-09-12 Thread Michel Dänzer
On 9/11/23 10:38, Pekka Paalanen wrote: > On Fri, 8 Sep 2023 17:10:46 +0200 > Thomas Zimmermann wrote: >> Am 08.09.23 um 16:41 schrieb Pekka Paalanen: >>> On Fri, 8 Sep 2023 15:56:51 +0200 >>> Thomas Zimmermann wrote: I have a number of concerns. My point it not that we shouldn't

Re: [PATCH v3] drm/plane: Add documentation about software color conversion.

2023-09-11 Thread Maxime Ripard
On Fri, Sep 08, 2023 at 05:37:27PM +0200, Thomas Zimmermann wrote: > > > Please note that the kernel's conversion code uses memory allocation > > > of intermediate buffers. We even recently had a discussion about > > > allocation overhead during display updates. Userspace can surely do > > > a

Re: [PATCH v3] drm/plane: Add documentation about software color conversion.

2023-09-11 Thread Thomas Zimmermann
Hi Am 11.09.23 um 12:05 schrieb Jocelyn Falempe: [...] Optimization always depends on the workload; something that the driver doesn't know. For example, as we mostly move the mouse cursor around the screen, the damages areas are usually small. Optimizing this might be pointless in any case.

Re: [PATCH v3] drm/plane: Add documentation about software color conversion.

2023-09-11 Thread Thomas Zimmermann
Hi Am 11.09.23 um 10:38 schrieb Pekka Paalanen: [...] In the kernel, we reduce the copying to the changed parts, if we have damage information from userspace. IDK Mesa's software renderer, but it could certainly apply a similar optimization. I have already assumed that everything uses damage

Re: [PATCH v3] drm/plane: Add documentation about software color conversion.

2023-09-11 Thread Jocelyn Falempe
On 08/09/2023 17:37, Thomas Zimmermann wrote: Hi Am 08.09.23 um 16:48 schrieb Jocelyn Falempe: On 08/09/2023 15:56, Thomas Zimmermann wrote: Hi Am 08.09.23 um 13:16 schrieb Pekka Paalanen: On Fri, 8 Sep 2023 11:21:51 +0200 Thomas Zimmermann wrote: Hi Am 25.08.23 um 16:04 schrieb Jocelyn

Re: [PATCH v3] drm/plane: Add documentation about software color conversion.

2023-09-11 Thread Pekka Paalanen
On Fri, 8 Sep 2023 17:10:46 +0200 Thomas Zimmermann wrote: > Hi > > Am 08.09.23 um 16:41 schrieb Pekka Paalanen: > > On Fri, 8 Sep 2023 15:56:51 +0200 > > Thomas Zimmermann wrote: > > > >> Hi > >> > >> Am 08.09.23 um 13:16 schrieb Pekka Paalanen: > >>> On Fri, 8 Sep 2023 11:21:51 +0200 >

Re: [PATCH v3] drm/plane: Add documentation about software color conversion.

2023-09-08 Thread Thomas Zimmermann
Hi Am 08.09.23 um 16:48 schrieb Jocelyn Falempe: On 08/09/2023 15:56, Thomas Zimmermann wrote: Hi Am 08.09.23 um 13:16 schrieb Pekka Paalanen: On Fri, 8 Sep 2023 11:21:51 +0200 Thomas Zimmermann wrote: Hi Am 25.08.23 um 16:04 schrieb Jocelyn Falempe: [...] + * + * But there are two

Re: [PATCH v3] drm/plane: Add documentation about software color conversion.

2023-09-08 Thread Thomas Zimmermann
Hi Am 08.09.23 um 16:41 schrieb Pekka Paalanen: On Fri, 8 Sep 2023 15:56:51 +0200 Thomas Zimmermann wrote: Hi Am 08.09.23 um 13:16 schrieb Pekka Paalanen: On Fri, 8 Sep 2023 11:21:51 +0200 Thomas Zimmermann wrote: Hi Am 25.08.23 um 16:04 schrieb Jocelyn Falempe: [...] + * + *

Re: [PATCH v3] drm/plane: Add documentation about software color conversion.

2023-09-08 Thread Jocelyn Falempe
On 08/09/2023 15:56, Thomas Zimmermann wrote: Hi Am 08.09.23 um 13:16 schrieb Pekka Paalanen: On Fri, 8 Sep 2023 11:21:51 +0200 Thomas Zimmermann wrote: Hi Am 25.08.23 um 16:04 schrieb Jocelyn Falempe: [...] + * + * But there are two exceptions only for dumb buffers: + * * To

Re: [PATCH v3] drm/plane: Add documentation about software color conversion.

2023-09-08 Thread Pekka Paalanen
On Fri, 8 Sep 2023 15:56:51 +0200 Thomas Zimmermann wrote: > Hi > > Am 08.09.23 um 13:16 schrieb Pekka Paalanen: > > On Fri, 8 Sep 2023 11:21:51 +0200 > > Thomas Zimmermann wrote: > > > >> Hi > >> > >> Am 25.08.23 um 16:04 schrieb Jocelyn Falempe: > >> [...] > >>> + * > >>> + * But

Re: [PATCH v3] drm/plane: Add documentation about software color conversion.

2023-09-08 Thread Thomas Zimmermann
Hi Jocelyn Am 08.09.23 um 16:06 schrieb Jocelyn Falempe: [...] And know I find that this patch (even in its v1) contains language that retroactively legitimizes the mgag200 patch. I wrote 'apparently' I my reply, as I assume that there's more to it, but how does it not look like an attempt to

Re: [PATCH v3] drm/plane: Add documentation about software color conversion.

2023-09-08 Thread Thomas Zimmermann
Hi Javier Am 08.09.23 um 15:46 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Hello Thomas, Hi Maxime Am 08.09.23 um 12:58 schrieb Maxime Ripard: Hi, On Fri, Sep 08, 2023 at 11:21:51AM +0200, Thomas Zimmermann wrote: Am 25.08.23 um 16:04 schrieb Jocelyn Falempe: [...] + *

Re: [PATCH v3] drm/plane: Add documentation about software color conversion.

2023-09-08 Thread Jocelyn Falempe
On 08/09/2023 15:46, Javier Martinez Canillas wrote: Thomas Zimmermann writes: Hello Thomas, Hi Maxime Am 08.09.23 um 12:58 schrieb Maxime Ripard: Hi, On Fri, Sep 08, 2023 at 11:21:51AM +0200, Thomas Zimmermann wrote: Am 25.08.23 um 16:04 schrieb Jocelyn Falempe: [...] + * + * But

Re: [PATCH v3] drm/plane: Add documentation about software color conversion.

2023-09-08 Thread Thomas Zimmermann
Hi Am 08.09.23 um 13:16 schrieb Pekka Paalanen: On Fri, 8 Sep 2023 11:21:51 +0200 Thomas Zimmermann wrote: Hi Am 25.08.23 um 16:04 schrieb Jocelyn Falempe: [...] + * + * But there are two exceptions only for dumb buffers: + * * To support XRGB if it's not supported by the

Re: [PATCH v3] drm/plane: Add documentation about software color conversion.

2023-09-08 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, > Hi Maxime > > Am 08.09.23 um 12:58 schrieb Maxime Ripard: >> Hi, >> >> On Fri, Sep 08, 2023 at 11:21:51AM +0200, Thomas Zimmermann wrote: >>> Am 25.08.23 um 16:04 schrieb Jocelyn Falempe: >>> [...] + * + * But there are two exceptions

Re: [PATCH v3] drm/plane: Add documentation about software color conversion.

2023-09-08 Thread Simon Ser
On Friday, September 8th, 2023 at 22:22, Thomas Zimmermann wrote: > Am 08.09.23 um 12:58 schrieb Maxime Ripard: > > > Hi, > > > > On Fri, Sep 08, 2023 at 11:21:51AM +0200, Thomas Zimmermann wrote: > > > > > Am 25.08.23 um 16:04 schrieb Jocelyn Falempe: > > > [...] > > > > > > > + * > > > >

Re: [PATCH v3] drm/plane: Add documentation about software color conversion.

2023-09-08 Thread Thomas Zimmermann
Hi Maxime Am 08.09.23 um 12:58 schrieb Maxime Ripard: Hi, On Fri, Sep 08, 2023 at 11:21:51AM +0200, Thomas Zimmermann wrote: Am 25.08.23 um 16:04 schrieb Jocelyn Falempe: [...] + * + * But there are two exceptions only for dumb buffers: + * * To support XRGB if it's not supported

Re: [PATCH v3] drm/plane: Add documentation about software color conversion.

2023-09-08 Thread Pekka Paalanen
On Fri, 8 Sep 2023 11:21:51 +0200 Thomas Zimmermann wrote: > Hi > > Am 25.08.23 um 16:04 schrieb Jocelyn Falempe: > [...] > > + * > > + * But there are two exceptions only for dumb buffers: > > + * * To support XRGB if it's not supported by the hardware. > > > > + * * Any

Re: [PATCH v3] drm/plane: Add documentation about software color conversion.

2023-09-08 Thread Maxime Ripard
Hi, On Fri, Sep 08, 2023 at 11:21:51AM +0200, Thomas Zimmermann wrote: > Am 25.08.23 um 16:04 schrieb Jocelyn Falempe: > [...] > > + * > > + * But there are two exceptions only for dumb buffers: > > + * * To support XRGB if it's not supported by the hardware. > > > > + * * Any

Re: [PATCH v3] drm/plane: Add documentation about software color conversion.

2023-09-08 Thread Thomas Zimmermann
Hi Am 25.08.23 um 16:04 schrieb Jocelyn Falempe: [...] + * + * But there are two exceptions only for dumb buffers: + * * To support XRGB if it's not supported by the hardware. + * * Any driver is free to modify its internal representation of the format, + * as long as

Re: [PATCH v3] drm/plane: Add documentation about software color conversion.

2023-08-28 Thread Pekka Paalanen
On Fri, 25 Aug 2023 16:04:18 +0200 Jocelyn Falempe wrote: > After discussions on IRC, the consensus is that the DRM drivers should > avoid software color conversion, and only advertise the formats supported > by hardware. > Update the doc accordingly so that the rule and exceptions are clear for

Re: [PATCH v3] drm/plane: Add documentation about software color conversion.

2023-08-25 Thread Javier Martinez Canillas
Jocelyn Falempe writes: Hello Jocelyn, > After discussions on IRC, the consensus is that the DRM drivers should > avoid software color conversion, and only advertise the formats supported > by hardware. > Update the doc accordingly so that the rule and exceptions are clear for > everyone. > >

Re: [PATCH v3] drm/plane: Add documentation about software color conversion.

2023-08-25 Thread Maxime Ripard
On Fri, 25 Aug 2023 16:04:18 +0200, Jocelyn Falempe wrote: > After discussions on IRC, the consensus is that the DRM drivers should > avoid software color conversion, and only advertise the formats supported > by hardware. > Update the doc accordingly so that the rule and exceptions are clear for

[PATCH v3] drm/plane: Add documentation about software color conversion.

2023-08-25 Thread Jocelyn Falempe
After discussions on IRC, the consensus is that the DRM drivers should avoid software color conversion, and only advertise the formats supported by hardware. Update the doc accordingly so that the rule and exceptions are clear for everyone. Acked-by: Simon Ser Signed-off-by: Jocelyn Falempe ---