Re: [PATCH v3] gpu/drm: mediatek: call mtk_dsi_stop() after mtk_drm_crtc_atomic_disable()

2019-05-30 Thread CK Hu
Hi, Hsin-Yi: On Thu, 2019-05-30 at 10:55 +0800, Hsin-Yi Wang wrote: > On Tue, May 28, 2019 at 4:53 PM CK Hu wrote: > > > I think we've already discussed in [1]. I need a reason to understand > > this is hardware behavior or software bug. If this is a software bug, we > > need to fix the bug and

Re: [PATCH v3] gpu/drm: mediatek: call mtk_dsi_stop() after mtk_drm_crtc_atomic_disable()

2019-05-29 Thread Hsin-Yi Wang
On Tue, May 28, 2019 at 4:53 PM CK Hu wrote: > I think we've already discussed in [1]. I need a reason to understand > this is hardware behavior or software bug. If this is a software bug, we > need to fix the bug and code could be symmetric. > > [1] >

Re: [PATCH v3] gpu/drm: mediatek: call mtk_dsi_stop() after mtk_drm_crtc_atomic_disable()

2019-05-28 Thread CK Hu
Hi, Hsin-Yi: On Tue, 2019-05-28 at 15:39 +0800, Hsin-Yi Wang wrote: > mtk_dsi_stop() should be called after mtk_drm_crtc_atomic_disable(), which > needs > ovl irq for drm_crtc_wait_one_vblank(), since after mtk_dsi_stop() is called, > ovl irq will be disabled. If drm_crtc_wait_one_vblank() is

[PATCH v3] gpu/drm: mediatek: call mtk_dsi_stop() after mtk_drm_crtc_atomic_disable()

2019-05-28 Thread Hsin-Yi Wang
mtk_dsi_stop() should be called after mtk_drm_crtc_atomic_disable(), which needs ovl irq for drm_crtc_wait_one_vblank(), since after mtk_dsi_stop() is called, ovl irq will be disabled. If drm_crtc_wait_one_vblank() is called after last irq, it will timeout with this message: "vblank wait timed out