Re: [PATCH v3 01/25] dma-mapping: add generic helpers for mapping sgtable objects

2020-05-07 Thread Hans Verkuil
Hi Marek, On 05/05/2020 10:45, Marek Szyprowski wrote: > struct sg_table is a common structure used for describing a memory > buffer. It consists of a scatterlist with memory pages and DMA addresses > (sgl entry), as well as the number of scatterlist entries: CPU pages > (orig_nents entry) and

Re: [PATCH v3 01/25] dma-mapping: add generic helpers for mapping sgtable objects

2020-05-05 Thread Marek Szyprowski
Hi Christoph, On 05.05.2020 12:22, Christoph Hellwig wrote: >> +static inline int dma_map_sgtable_attrs(struct device *dev, >> +struct sg_table *sgt, enum dma_data_direction dir, unsigned long attrs) > Two tab indents for parameter continuation, please. > > Can we also skip the separate

[PATCH v3 01/25] dma-mapping: add generic helpers for mapping sgtable objects

2020-05-05 Thread Marek Szyprowski
struct sg_table is a common structure used for describing a memory buffer. It consists of a scatterlist with memory pages and DMA addresses (sgl entry), as well as the number of scatterlist entries: CPU pages (orig_nents entry) and DMA pages (nents entry). It turned out that it was a common