Re: [PATCH v3 1/2] drm/msm/dpu: Modify vblank_refcount if error in callback

2023-12-01 Thread Dmitry Baryshkov
On Fri, 1 Dec 2023 at 21:14, Abhinav Kumar wrote: > > > > On 11/30/2023 11:45 PM, Dmitry Baryshkov wrote: > > On Fri, 1 Dec 2023 at 03:41, Paloma Arellano > > wrote: > >> > >> When the irq callback returns a value other than zero, > >> modify vblank_refcount by performing the inverse > >>

Re: [PATCH v3 1/2] drm/msm/dpu: Modify vblank_refcount if error in callback

2023-12-01 Thread Abhinav Kumar
On 11/30/2023 11:45 PM, Dmitry Baryshkov wrote: On Fri, 1 Dec 2023 at 03:41, Paloma Arellano wrote: When the irq callback returns a value other than zero, modify vblank_refcount by performing the inverse operation of its corresponding if-else condition. I think it might be better to

Re: [PATCH v3 1/2] drm/msm/dpu: Modify vblank_refcount if error in callback

2023-11-30 Thread Dmitry Baryshkov
On Fri, 1 Dec 2023 at 03:41, Paloma Arellano wrote: > > When the irq callback returns a value other than zero, > modify vblank_refcount by performing the inverse > operation of its corresponding if-else condition. I think it might be better to follow Bjorn's suggestion: once we have the lock, we

[PATCH v3 1/2] drm/msm/dpu: Modify vblank_refcount if error in callback

2023-11-30 Thread Paloma Arellano
When the irq callback returns a value other than zero, modify vblank_refcount by performing the inverse operation of its corresponding if-else condition. Signed-off-by: Paloma Arellano --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 9 +++--