Re: [PATCH v3 11/13] drm/fb-helper: Fix single-probe color-format selection

2023-05-26 Thread Linux regression tracking #update (Thorsten Leemhuis)
[TLDR: This mail in primarily relevant for Linux regression tracking. A change or fix related to the regression discussed in this thread was posted or applied, but it did not use a Link: tag to point to the report, as Linus and the documentation call for. Things happen, no worries -- but now the re

Re: [PATCH v3 11/13] drm/fb-helper: Fix single-probe color-format selection

2023-05-15 Thread Linus Walleij
On Mon, May 15, 2023 at 11:26 AM Thomas Zimmermann wrote: > > I think I found this, the bandwidth limit calculation in > > drivers/gpu/drm/pl111/pl111_display.c was using the bpp from > > the config and this was decreased from 16 to 15 and as it determined > > cpp by dividing bpp/8 this decreased

Re: [PATCH v3 11/13] drm/fb-helper: Fix single-probe color-format selection

2023-05-15 Thread Thomas Zimmermann
Hi Am 15.05.23 um 10:59 schrieb Linus Walleij: On Mon, May 15, 2023 at 10:17 AM Thomas Zimmermann wrote: Am 15.05.23 um 10:01 schrieb Linus Walleij: But the display is flickering like crazy so the updating frequency is totally off, which is because it does not scale down the resolution, the

Re: [PATCH v3 11/13] drm/fb-helper: Fix single-probe color-format selection

2023-05-15 Thread Linus Walleij
On Mon, May 15, 2023 at 10:17 AM Thomas Zimmermann wrote: > Am 15.05.23 um 10:01 schrieb Linus Walleij: > > But the display is flickering like crazy so the updating frequency is > > totally off, which is because it does not scale down the resolution, > > the print used to be: > > > > Console: swi

Re: [PATCH v3 11/13] drm/fb-helper: Fix single-probe color-format selection

2023-05-15 Thread Thomas Zimmermann
Hi Am 15.05.23 um 10:16 schrieb Daniel Vetter: On Fri, May 12, 2023 at 04:11:48PM +0200, Thomas Zimmermann wrote: Hi Am 12.05.23 um 15:20 schrieb Linus Walleij: Sorry for late regression detection but this patch regresses the Integrator AB IMPD-1 graphics, I bisected down to this patch. [...

Re: [PATCH v3 11/13] drm/fb-helper: Fix single-probe color-format selection

2023-05-15 Thread Thomas Zimmermann
Hi Am 15.05.23 um 10:01 schrieb Linus Walleij: On Fri, May 12, 2023 at 4:11 PM Thomas Zimmermann wrote: Any hints on how we can fix this? According to a quick grep for fb_bpp, it's only used for the call to drm_fbdev_dma_setup(), right? In this case, you should set it to 15 for the models w

Re: [PATCH v3 11/13] drm/fb-helper: Fix single-probe color-format selection

2023-05-15 Thread Daniel Vetter
On Fri, May 12, 2023 at 04:11:48PM +0200, Thomas Zimmermann wrote: > Hi > > Am 12.05.23 um 15:20 schrieb Linus Walleij: > > Sorry for late regression detection but this patch regresses > > the Integrator AB IMPD-1 graphics, I bisected down to this > > patch. > [...] > > This is the driver: > > dri

Re: [PATCH v3 11/13] drm/fb-helper: Fix single-probe color-format selection

2023-05-15 Thread Linus Walleij
On Fri, May 12, 2023 at 4:11 PM Thomas Zimmermann wrote: > > Any hints on how we can fix this? > > According to a quick grep for fb_bpp, it's only used for the call to > drm_fbdev_dma_setup(), right? In this case, you should set it to 15 for > the models without rgb565. The switch at [1] should t

Re: [PATCH v3 11/13] drm/fb-helper: Fix single-probe color-format selection

2023-05-14 Thread Linux regression tracking #adding (Thorsten Leemhuis)
[CCing the regression list, as it should be in the loop for regressions: https://docs.kernel.org/admin-guide/reporting-regressions.html] [TLDR: I'm adding this report to the list of tracked Linux kernel regressions; the text you find below is based on a few templates paragraphs you might have enco

Re: [PATCH v3 11/13] drm/fb-helper: Fix single-probe color-format selection

2023-05-12 Thread Thomas Zimmermann
Hi Am 12.05.23 um 15:20 schrieb Linus Walleij: Sorry for late regression detection but this patch regresses the Integrator AB IMPD-1 graphics, I bisected down to this patch. [...] This is the driver: drivers/gpu/drm/pl111/pl111_versatile.c with the pl110_impd1 variant, so these are the support

Re: [PATCH v3 11/13] drm/fb-helper: Fix single-probe color-format selection

2023-05-12 Thread Linus Walleij
Sorry for late regression detection but this patch regresses the Integrator AB IMPD-1 graphics, I bisected down to this patch. On Mon, Jan 2, 2023 at 12:30 PM Thomas Zimmermann wrote: > Fix the color-format selection of the single-probe helper. Go > through all user-specified values and test eac

Re: [PATCH v3 11/13] drm/fb-helper: Fix single-probe color-format selection

2023-01-04 Thread Maíra Canal
On 1/4/23 05:14, Thomas Zimmermann wrote: Hi Thanks for reporting the problem. Am 03.01.23 um 22:18 schrieb Maíra Canal: Hi Thomas, On 1/2/23 08:29, Thomas Zimmermann wrote: Fix the color-format selection of the single-probe helper. Go through all user-specified values and test each for comp

Re: [PATCH v3 11/13] drm/fb-helper: Fix single-probe color-format selection

2023-01-04 Thread Thomas Zimmermann
Hi Thanks for reporting the problem. Am 03.01.23 um 22:18 schrieb Maíra Canal: Hi Thomas, On 1/2/23 08:29, Thomas Zimmermann wrote: Fix the color-format selection of the single-probe helper. Go through all user-specified values and test each for compatibility with the driver. If none is suppo

Re: [PATCH v3 11/13] drm/fb-helper: Fix single-probe color-format selection

2023-01-03 Thread Maíra Canal
Hi Thomas, On 1/2/23 08:29, Thomas Zimmermann wrote: Fix the color-format selection of the single-probe helper. Go through all user-specified values and test each for compatibility with the driver. If none is supported, use the driver-provided default. This guarantees that the console is always

[PATCH v3 11/13] drm/fb-helper: Fix single-probe color-format selection

2023-01-02 Thread Thomas Zimmermann
Fix the color-format selection of the single-probe helper. Go through all user-specified values and test each for compatibility with the driver. If none is supported, use the driver-provided default. This guarantees that the console is always available in any color format at least. Until now, the