Re: [PATCH v3 11/13] drm/sched: Waiting for pending jobs to complete in scheduler kill

2023-09-18 Thread Christian König
Am 18.09.23 um 16:57 schrieb Danilo Krummrich: [SNIP] What this component should do is to push jobs to the hardware and not overview their execution, that's the job of the driver. While, generally, I'd agree, I think we can't really get around having something that frees the job once it's

Re: [PATCH v3 11/13] drm/sched: Waiting for pending jobs to complete in scheduler kill

2023-09-18 Thread Danilo Krummrich
On 9/18/23 13:03, Christian König wrote: Am 16.09.23 um 19:52 schrieb Danilo Krummrich: On 9/12/23 16:47, Matthew Brost wrote: On Tue, Sep 12, 2023 at 11:57:30AM +0200, Christian König wrote: Am 12.09.23 um 04:16 schrieb Matthew Brost: Wait for pending jobs to be complete before signaling

Re: [PATCH v3 11/13] drm/sched: Waiting for pending jobs to complete in scheduler kill

2023-09-18 Thread Christian König
Am 16.09.23 um 19:52 schrieb Danilo Krummrich: On 9/12/23 16:47, Matthew Brost wrote: On Tue, Sep 12, 2023 at 11:57:30AM +0200, Christian König wrote: Am 12.09.23 um 04:16 schrieb Matthew Brost: Wait for pending jobs to be complete before signaling queued jobs. This ensures dma-fence

Re: [PATCH v3 11/13] drm/sched: Waiting for pending jobs to complete in scheduler kill

2023-09-16 Thread Danilo Krummrich
On 9/12/23 16:47, Matthew Brost wrote: On Tue, Sep 12, 2023 at 11:57:30AM +0200, Christian König wrote: Am 12.09.23 um 04:16 schrieb Matthew Brost: Wait for pending jobs to be complete before signaling queued jobs. This ensures dma-fence signaling order correct and also ensures the entity is

Re: [PATCH v3 11/13] drm/sched: Waiting for pending jobs to complete in scheduler kill

2023-09-12 Thread Matthew Brost
On Tue, Sep 12, 2023 at 12:28:28PM +0200, Boris Brezillon wrote: > On Mon, 11 Sep 2023 19:16:13 -0700 > Matthew Brost wrote: > > > +void drm_sched_add_pending_job(struct drm_sched_job *job, bool tail) > > +{ > > + struct drm_gpu_scheduler *sched = job->sched; > > + struct drm_sched_entity

Re: [PATCH v3 11/13] drm/sched: Waiting for pending jobs to complete in scheduler kill

2023-09-12 Thread Matthew Brost
On Tue, Sep 12, 2023 at 11:57:30AM +0200, Christian König wrote: > Am 12.09.23 um 04:16 schrieb Matthew Brost: > > Wait for pending jobs to be complete before signaling queued jobs. This > > ensures dma-fence signaling order correct and also ensures the entity is > > not running on the hardware

Re: [PATCH v3 11/13] drm/sched: Waiting for pending jobs to complete in scheduler kill

2023-09-12 Thread Boris Brezillon
On Mon, 11 Sep 2023 19:16:13 -0700 Matthew Brost wrote: > +void drm_sched_add_pending_job(struct drm_sched_job *job, bool tail) > +{ > + struct drm_gpu_scheduler *sched = job->sched; > + struct drm_sched_entity *entity = job->entity; drm_sched_entity_pop_job() sets job->entity to NULL

Re: [PATCH v3 11/13] drm/sched: Waiting for pending jobs to complete in scheduler kill

2023-09-12 Thread Christian König
Am 12.09.23 um 04:16 schrieb Matthew Brost: Wait for pending jobs to be complete before signaling queued jobs. This ensures dma-fence signaling order correct and also ensures the entity is not running on the hardware after drm_sched_entity_flush or drm_sched_entity_fini returns. Entities are

Re: [PATCH v3 11/13] drm/sched: Waiting for pending jobs to complete in scheduler kill

2023-09-12 Thread Boris Brezillon
On Mon, 11 Sep 2023 19:16:13 -0700 Matthew Brost wrote: > Wait for pending jobs to be complete before signaling queued jobs. You probably want to add 'in drm_sched_entity_kill()', even if it's already specified in the subject, because I was trying to understand why we'd want to do that in the

[PATCH v3 11/13] drm/sched: Waiting for pending jobs to complete in scheduler kill

2023-09-11 Thread Matthew Brost
Wait for pending jobs to be complete before signaling queued jobs. This ensures dma-fence signaling order correct and also ensures the entity is not running on the hardware after drm_sched_entity_flush or drm_sched_entity_fini returns. Signed-off-by: Matthew Brost ---