Re: [PATCH v3 16/24] drm/sun4i: Enable DW HDMI PHY clock

2018-07-01 Thread Jernej Škrabec
Dne četrtek, 28. junij 2018 ob 04:22:36 CEST je Chen-Yu Tsai napisal(a): > On Mon, Jun 25, 2018 at 8:02 PM, Jernej Skrabec wrote: > > Current DW HDMI PHY code never prepares and enables PHY clock after it is > > created. It's just used as it is. This may work in some cases, but it's > > clearly

Re: [PATCH v3 16/24] drm/sun4i: Enable DW HDMI PHY clock

2018-06-29 Thread Chen-Yu Tsai
On Sat, Jun 30, 2018 at 3:19 AM, Jernej Škrabec wrote: > Dne četrtek, 28. junij 2018 ob 04:22:36 CEST je Chen-Yu Tsai napisal(a): >> On Mon, Jun 25, 2018 at 8:02 PM, Jernej Skrabec > wrote: >> > Current DW HDMI PHY code never prepares and enables PHY clock after it is >> > created. It's just

Re: [PATCH v3 16/24] drm/sun4i: Enable DW HDMI PHY clock

2018-06-28 Thread Jernej Škrabec
Dne četrtek, 28. junij 2018 ob 04:22:36 CEST je Chen-Yu Tsai napisal(a): > On Mon, Jun 25, 2018 at 8:02 PM, Jernej Skrabec wrote: > > Current DW HDMI PHY code never prepares and enables PHY clock after it is > > created. It's just used as it is. This may work in some cases, but it's > > clearly

Re: [PATCH v3 16/24] drm/sun4i: Enable DW HDMI PHY clock

2018-06-27 Thread Chen-Yu Tsai
On Mon, Jun 25, 2018 at 8:02 PM, Jernej Skrabec wrote: > Current DW HDMI PHY code never prepares and enables PHY clock after it is > created. It's just used as it is. This may work in some cases, but it's > clearly wrong. Fix it by adding proper calls to enable/disable PHY > clock. > > Fixes:

[PATCH v3 16/24] drm/sun4i: Enable DW HDMI PHY clock

2018-06-26 Thread Jernej Skrabec
Current DW HDMI PHY code never prepares and enables PHY clock after it is created. It's just used as it is. This may work in some cases, but it's clearly wrong. Fix it by adding proper calls to enable/disable PHY clock. Fixes: 4f86e81748fe ("drm/sun4i: Add support for H3 HDMI PHY variant")